Skip to content

Commit

Permalink
Merge pull request #1907 from camilamacedo86/add-marker-extension
Browse files Browse the repository at this point in the history
✨ add new extension to markers in order to allow work with .yml
  • Loading branch information
k8s-ci-robot committed Dec 15, 2020
2 parents 0a807f4 + 7dc4d33 commit a4ad49a
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions pkg/model/file/marker.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ var commentsByExt = map[string]string{
// this is a backwards incompatible change, and thus should be done for next project version.
".go": "// ",
".yaml": "# ",
".yml": "#",
// When adding additional file extensions, update also the NewMarkerFor documentation and error
}

Expand All @@ -38,14 +39,14 @@ type Marker struct {
}

// NewMarkerFor creates a new marker customized for the specific file
// Supported file extensions: .go, .ext
// Supported file extensions: .go, .yaml, .yml
func NewMarkerFor(path string, value string) Marker {
ext := filepath.Ext(path)
if comment, found := commentsByExt[ext]; found {
return Marker{comment, value}
}

panic(fmt.Errorf("unknown file extension: '%s', expected '.go' or '.yaml'", ext))
panic(fmt.Errorf("unknown file extension: '%s', expected '.go', '.yaml' or '.yml'", ext))
}

// String implements Stringer
Expand Down

0 comments on commit a4ad49a

Please sign in to comment.