Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add new extension to markers in order to allow work with .yml #1907

Merged
merged 1 commit into from
Dec 15, 2020
Merged

✨ add new extension to markers in order to allow work with .yml #1907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/model/file/marker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ var commentsByExt = map[string]string{
// this is a backwards incompatible change, and thus should be done for next project version.
".go": "// ",
".yaml": "# ",
".yml": "#",
// When adding additional file extensions, update also the NewMarkerFor documentation and error
}

Expand All @@ -38,14 +39,14 @@ type Marker struct {
}

// NewMarkerFor creates a new marker customized for the specific file
// Supported file extensions: .go, .ext
// Supported file extensions: .go, .yaml, .yml
func NewMarkerFor(path string, value string) Marker {
ext := filepath.Ext(path)
if comment, found := commentsByExt[ext]; found {
return Marker{comment, value}
}

panic(fmt.Errorf("unknown file extension: '%s', expected '.go' or '.yaml'", ext))
panic(fmt.Errorf("unknown file extension: '%s', expected '.go', '.yaml' or '.yml'", ext))
}

// String implements Stringer
Expand Down