Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[idea] helm-operator event/hook system #4695

Closed
SimonBaeumer opened this issue Mar 24, 2021 · 6 comments
Closed

[idea] helm-operator event/hook system #4695

SimonBaeumer opened this issue Mar 24, 2021 · 6 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/helm Issue is related to a Helm operator project lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Milestone

Comments

@SimonBaeumer
Copy link
Member

Feature Request

Describe the problem you need a feature to resolve.

To maintain a helm-chart and an operator in parallel we would like to re-use as much as possible from our helm-chart.
Given that helm is limited in it's feature set the helm-operator can only support Level II operators.
I started trying to re-invent the wheel to render the k8s objects based on our helm-chart and do everything the helm-operator does only to interact under specific circumstances differently, i.e. creating backups or recovering from an error.

Describe the solution you'd like.

I am looking for a way to create a Go controller which uses the helm-operator but gives me the ability to customize at specific lifecycle events.
A basic idea would be to create an event-system or callback functions which are executed at specific events like installation, reconciliation or deletion. This would give me the chance to look at the current state and decide how to proceed before helm applies any changes.

Further it would allow us to created CRDs which are independent from our values.yaml and overall more flexibility.

I am curios what you are thinking about this approach.

Thanks in advance!

Best regards,
Simon

@SimonBaeumer
Copy link
Member Author

The issue #670 about supporting hybrid operators could be related to this idea.

@estroz estroz self-assigned this Mar 29, 2021
@estroz estroz added kind/feature Categorizes issue or PR as related to a new feature. language/helm Issue is related to a Helm operator project labels Mar 29, 2021
@estroz estroz added this to the Backlog milestone Mar 29, 2021
@estroz
Copy link
Member

estroz commented Mar 29, 2021

Great request! In fact, a redesign of the helm-operator's API is in flight that adds hook registration amongst other things.

@estroz estroz modified the milestones: Backlog, v2.0.0 Mar 29, 2021
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 27, 2021
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 27, 2021
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci
Copy link

openshift-ci bot commented Aug 27, 2021

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this as completed Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/helm Issue is related to a Helm operator project lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants