Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin cryptography Python dep for Ansible Operators #5739

Closed
asmacdo opened this issue May 9, 2022 · 10 comments · Fixed by #6269
Closed

Unpin cryptography Python dep for Ansible Operators #5739

asmacdo opened this issue May 9, 2022 · 10 comments · Fixed by #6269
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@asmacdo
Copy link
Member

asmacdo commented May 9, 2022

We've got this version pinned
https://github.com/operator-framework/operator-sdk/blob/master/images/ansible-operator/Pipfile#L13-L16

It looks like the rust toolkit is available for UBI 8 now, so I think we can start bumping this dep.

Might affect #5619

@asmacdo asmacdo added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 23, 2022
@asmacdo asmacdo added this to the Backlog milestone May 23, 2022
@varshaprasad96 varshaprasad96 changed the title Unpin cryptogrophy Python dep for Ansible Operators Unpin cryptography Python dep for Ansible Operators Jun 8, 2022
@varshaprasad96 varshaprasad96 modified the milestones: Backlog, v1.23.0 Jun 8, 2022
@asmacdo asmacdo added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 29, 2022
@asmacdo
Copy link
Member Author

asmacdo commented Jun 29, 2022

This should be pretty easy if anyone wants to pick it up, I'd be willing to coach.

@rudradevpal
Copy link

/assign

@asmacdo
Copy link
Member Author

asmacdo commented Jul 5, 2022

Hi @rudradevpal thank you for picking this up!

For this one, you can start by updating the pipfile and then using pipenv to update the .lock file. (Let me know if you need some docs links to figure that out.)

From there, you can use make image-build ansible-operator to build the image.

image-build: $(foreach i,$(IMAGE_TARGET_LIST),image/$(i)) ## Build all images.

Try out the new image with any ansible-based operator (Memcached tutorial is fine) to make sure it all works.

Repeat for Ansible 2.11 preview image.

Let me know if you could use any assistance!

@rudradevpal
Copy link

rudradevpal commented Jul 5, 2022

@asmacdo can you please share docs for

  1. pipenv to update the .lock file
  2. for building and testing

do i just remove the cryptography"==3.3.2" or just change to ~=3.3.2

@rudradevpal
Copy link

@asmacdo Can you please help on this issue. Waiting for your reply

@asmacdo
Copy link
Member Author

asmacdo commented Jul 7, 2022

Let's unpin for now.

Use pipenv to install dependencies (from the pipfile) into a temp virtualenv, and it should update the lock file.
https://pipenv.pypa.io/en/latest/

@rudradevpal
Copy link

rudradevpal commented Jul 7, 2022

So i am just going with putting cryptography= "*" as of now.
Also it will help if you can provide doc to test operator-sdk @asmacdo

@asmacdo
Copy link
Member Author

asmacdo commented Jul 7, 2022

For building and testing, take a look at the makefile. make image-build ansible-operator (also ansible-operator-2.11-preview) will build the images.

Once the images are building, you should be ok to push a PR and let CI run.

@rudradevpal
Copy link

Okay thanks @asmacdo

@asmacdo asmacdo modified the milestones: v1.23.0, v1.24.0 Jul 20, 2022
@asmacdo asmacdo modified the milestones: v1.24.0, v1.25.0 Sep 21, 2022
@theishshah theishshah added this to the v1.25.0 milestone Sep 26, 2022
@jberkhahn jberkhahn modified the milestones: v1.25.0, v1.26.0 Oct 12, 2022
@jmrodri jmrodri modified the milestones: v1.26.0, v1.27.0 Nov 2, 2022
@varshaprasad96
Copy link
Member

@rudradevpal Would you like still pick up this issue. If not feel free to unassigned yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants