Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause and Resume watch/reconcile of custom resource by helm-operator #5803

Closed
sukhil-suresh opened this issue May 24, 2022 · 6 comments
Closed
Assignees
Labels
language/helm Issue is related to a Helm operator project lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs discussion
Milestone

Comments

@sukhil-suresh
Copy link

Feature Request

Describe the problem you need a feature to resolve.

For a particular scenario, we temporarily scale down a deployment (which is part of our product) by updating the replica value to zero in the spec. However, it seems the helm-operator-controller interferes with this and scales it back up to the replica count set for the operand install.

Describe the solution you'd like.

It would be very helpful if the helm controller could temporarily pause reconciliation for a resource and then resume later. Maybe this could be triggered by a paused annotation on the resource?

The operator-lib project has support for such a feature - operator-framework/operator-lib#60

If such a feature already exists for the helm-operator, kindly guide us with the related resource.

/language helm

@openshift-ci openshift-ci bot added the language/helm Issue is related to a Helm operator project label May 24, 2022
@jberkhahn jberkhahn added this to the Backlog milestone Jun 6, 2022
@varshaprasad96
Copy link
Member

@sukhil-suresh Unfortunately, we don't have this feature in Helm operators. The available set of annotations for Helm operators are here: https://sdk.operatorframework.io/docs/building-operators/helm/reference/advanced_features/annotations/.

@sukhil-suresh
Copy link
Author

sukhil-suresh commented Jun 13, 2022

@varshaprasad96 Thanks for sharing the annotations supported by the Helm operator.

We have an (untested) workaround for the problem we faced, which involves updating the operand spec to have support for the deployment replica. The assumption is that the helm operator will respect the operand spec value change.

Feel free to close the issue, if needed. I still believe there is value in an annotation that allows pause/resume of the helm-based operator reconciliation.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 12, 2022
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 13, 2022
@sukhil-suresh
Copy link
Author

/close

@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2022

@sukhil-suresh: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this as completed Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/helm Issue is related to a Helm operator project lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs discussion
Projects
None yet
Development

No branches or pull requests

4 participants