-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm overrideValues will not work for booleans #6115
Comments
A map of strings per default. |
@xrow As you have pointed out correctly, this is because the /kind feature |
/unassign jmrodri |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
In the context of "hybrid" helm operators, can OverrideValues be more than a map of strings somehow ? If i am packaging a helm chart as an operator, is anything additional a hybrid operator can do limited to adding a different controller ? .. If so, the only way to override non string values is by specifying things in spec of the "helm" cr ? I wanted to check if I have some incorrect assumptions. |
Trying to do something like this so that OverrideValues don't have to be set in spec : https://github.com/skattoju/airflow-hybrid-operator/blob/afd9e854876fe487ce503285a34c5935c8bb064e/watches.yaml#L9 |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
One way to resolve this is by passing a value translator function to the reconciler[1] like the example in [2] [1] https://github.com/operator-framework/helm-operator-plugins/blob/7eacb666f7941ae3f1084c5b01fc26811e715379/pkg/reconciler/reconciler.go#L451 |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
operator-sdk has limitation to override boolean value. operator-framework/operator-sdk#6115 This commit allows string type of the flag, so we can override it from helm-operator level.
Bug Report
What did you do?
When susing the helm operator sdk I have an issue with override vars not being strings.
My watches looks like this
What did you expect to see?
no issue when using my operator
What did you see instead? Under which circumstances?
From the pod log from the operator:
{"level":"error","ts":1666869259.3604903,"logger":"helm.controller","msg":"Failed to sync release","namespace":"test1","name":"ibexa","apiVersion":"xrow.com/v1","kind":"Ibexa","release":"ibexa","error":"failed to get candidate release: values don't meet the specifications of the schema(s) in the following chart(s):\nibexa:\n- installation.enabled: Invalid type. Expected: boolean, given: string\n","stacktrace":"github.com/operator-framework/operator-sdk/internal/helm/controller.HelmOperatorReconciler.Reconcile\n\t/workspace/internal/helm/controller/reconcile.go:218\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.0/pkg/internal/controller/controller.go:121\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.0/pkg/internal/controller/controller.go:320\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.0/pkg/internal/controller/controller.go:273\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.0/pkg/internal/controller/controller.go:234"}
Environment
Operator type:
language helm
Kubernetes cluster type:
OpenShift 3.11
$ operator-sdk version
1.25.0
$ kubectl version
not applicable
Possible Solution
make false, true, False, True not quoted or keep the type somehow.
Additional context
My chart has a schema json that can validate the values
such as
The text was updated successfully, but these errors were encountered: