Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Go version 1.21 #6722

Closed
BrimstoneXmk opened this issue Apr 18, 2024 · 8 comments
Closed

Support for Go version 1.21 #6722

BrimstoneXmk opened this issue Apr 18, 2024 · 8 comments
Assignees
Labels
area/dependency Issues or PRs related to dependency changes
Milestone

Comments

@BrimstoneXmk
Copy link

Bug Report

What did you do?

ref to this issue: #6644

What did you expect to see?

Support for Go 1.21 PR to be merged for release 1.34.1 branch for ansible-operator-plugin

What did you see instead? Under which circumstances?

The ansible-operator-plugin for 1.34.1 release branch doesn't have the Bump go to 1.21 PR cherry-picked which directly could have resolved this issue Support for Go version 1.21. This issue is marked as resolved Overall, from the changelog point of view, this hasn't been resolved yet in 1.34.1 or 1.34.0 version.

Environment

Operator type: Ansible

Kubernetes cluster type:

$ operator-sdk version: v1.34.1

$ go version (if language is Go): go1.20.14

$ kubectl version: v1.28.0

Possible Solution

The ansible-operator-plugin for 1.34.1 release branch doesn't have the Bump go to 1.21 PR cherry-picked which directly can resolve this issue.

Additional context

@BrimstoneXmk
Copy link
Author

BrimstoneXmk commented Apr 18, 2024

@oceanc80, @rashmigottipati could you please confirm if this can be fixed promptly?

@tarunkalra7
Copy link

tarunkalra7 commented May 2, 2024

FYI @everettraven @varshaprasad96 Any update on this? Facing same issue

I checked the changelog here and I couldn't find the go version 1.21 PR

@jberkhahn
Copy link
Contributor

jberkhahn commented May 6, 2024

We need to cut a release of ansible-operator-plugins and then bump our dependency on this and cut a release.

We're in the process of upgrading our dependencies, this should happen with that automatically.

@jberkhahn jberkhahn added the area/dependency Issues or PRs related to dependency changes label May 6, 2024
@jberkhahn jberkhahn added this to the Backlog milestone May 6, 2024
@jberkhahn jberkhahn self-assigned this May 6, 2024
@acornett21
Copy link
Contributor

@BrimstoneXmk
Copy link
Author

@jberkhahn Till when can we expect the next release?

@BrimstoneXmk
Copy link
Author

We can see that the latest release has happened for Ansible as well as for helm.
New version of operator SDK is available now : 1.34.2.
Checked Go version used in this new release.
For helm-operator, its upgraded to 1.21.10. Refer below output.

bash-4.4# helm-operator version
helm-operator version: "v1.34.2", commit: "81dd3cb24b8744de03d312c1ba23bfc617044005", kubernetes version: "v1.28.0", go version: "go1.21.10", GOOS: "linux", GOARCH: "amd64"

But for ansible-operator, new release is using Go 1.21.9 . Refer below output.

bash-4.4# ansible-operator version
ansible-operator version: "v1.34.2", commit: "1c1f3931cc40b75a6fd6f1dd48847f288abc748a", kubernetes version: "v1.28.0", go version: "go1.21.9", GOOS: "linux", GOARCH: "amd64"

can anyone explain why is this difference?

@stefanb
Copy link

stefanb commented Jul 23, 2024

Go 1.21 will become unsupported in August, so i opened an issue:

@acornett21
Copy link
Contributor

Going to close this since v1.36.0 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes
Projects
None yet
Development

No branches or pull requests

5 participants