-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update k8s dependencies #67
base: main
Are you sure you want to change the base?
Update k8s dependencies #67
Conversation
@rashmigottipati could you help review this PR? |
* Bump k8s dependencies to 0.29.3 * Bump other operator-framework lib versions to support k8s 0.29.x * Bump ginkgo/v2 to v2.17.2 TODO: * Update operator-framework/ansible-operator-plugins after operator-framework/ansible-operator-plugins#67 is merged * Add changelog * Regenerate testdata Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good, but I think we also need to make sure we update the python packages provided in the base image here:
kubernetes = "==28.1.0" |
pkg/plugins/ansible/v1/scaffolds/internal/templates/config/rbac/role.go
Outdated
Show resolved
Hide resolved
testdata/memcached-molecule-operator/config/default/manager_auth_proxy_patch.yaml
Outdated
Show resolved
Hide resolved
@everettraven could you review this PR again? |
59295f4
to
c1fc012
Compare
@everettraven could you review this PR since its blocking operator-framework/operator-sdk#6736? |
@everettraven / @rashmigottipati can you help review this PR? This blocking work on the 1.29 bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM aside from the comment that @acornett21 left
Made the specified changes. @everettraven, @acornett21 could you review again? |
* Bump k8s dependencies to 0.29.3 * Bump other operator-framework lib versions to support k8s 0.29.x * Bump ginkgo/v2 to v2.17.2 TODO: * Update operator-framework/ansible-operator-plugins after operator-framework/ansible-operator-plugins#67 is merged * Add changelog * Regenerate testdata Signed-off-by: Neo2308 <pradha.krishna.cse17@itbhu.ac.in>
The e2e-molecule test failure seems to be due to an environment issue, I don't seem to have the permissions to retrigger it. |
@Neo2308 I think I've re-ran this test 2 or 3 times, and it's still failing. |
@acornett21 could you help fix the build failure? |
* Updated k8s dependencies to v0.29.3 * Updated operator-framework/operator-registry to v1.39.0 * Updated kubebuilder to v3.14.1 * Updated k8s version in Makefile TODO: Update operator-framework/operator-lib after operator-framework/operator-lib#167 is merged
* Updated operator-framework/operator-lib to v1.39.0
Use NewDynamicRESTMapper instead of NewDiscoveryRESTMapper (Ref: kubernetes-sigs/controller-runtime#2611)
* Use operator-lib v0.13.0 instead of commit. * Regenerated testdata.
d85c877
to
9c82fc3
Compare
Rebased the PR onto latest master. @acornett21 could you approve the workflow runs? |
The sanity tests are passing locally now, @acornett21 / @everettraven could you run approve the workflow runs? |
@Neo2308 It doesn't appear that you generated the Azure/azure-iot-sdk-python#1182 Controller Logs
I'm not really sure how we work around this, since I'm not well versed in python. I poised this question in k8s slack |
@acornett21 Should we consider reverting the request package bump and ignore the security warning coming from it for now? By the way, really appreciate your help so far on this PR! |
@Neo2308 After the discussion in slack, @everettraven agrees the path forward for now is to revert the |
56d31fb
to
c5c8be1
Compare
c5c8be1
to
2e0f3ec
Compare
@acornett21 Made the changes. Could you review? |
Relates to: operator-framework/operator-sdk#6651