-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go mod support for new operators #1001
Conversation
General comments about this. From my experience with go modules you cannot have the project in a operator-sdk/internal/util/projutil/project_util.go Lines 89 to 90 in c81f98c
So I would think about how to first migrage out of needing to be in |
@lilic Perhaps |
This might be interesting: from the Go modules Wiki:
|
Hi @estroz , Just a notice, according to the Go WiKi - Modules
Thanks for your great work to make this happening! |
This PR is on the backburner for now, but I'll be getting back on it soon. @lilic I agree we should eliminate |
I'm not sure I understand the question, do you mean supported by the go team? (Yes) When it is available? (Now) Or it's API stability? (It is stated as stable as of December 1st 2018). |
They can, if the |
I have come accross additional info: https://godoc.org/github.com/rogpeppe/go-internal/modfile can be used to parse a modfile (which this PR implements additionnally). According to golang/go#30147 (which suggests to use the rogpeppe modfile fork) and golang/go#28101 the modfile should eventually graduate outside of internal. |
@estroz FYI there is an upstream PR to add |
Note: prow CI jobs will fail until we update the CI base image to go 1.11+ |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after addressing the above comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Using an unreleased version of `operator-sdk` which permits to build/run the operator outside of `GOPATH` using Go modules properly. See: operator-framework/operator-sdk#1001
Using an unreleased version of `operator-sdk` which permits to build/run the operator outside of `GOPATH` using Go modules properly. Note: the CRD `scope` is manually changed to `Cluster` after code/YAML-generation. See: operator-framework/operator-sdk#1001
Using an unreleased version of `operator-sdk` which permits to build/run the operator outside of `GOPATH` using Go modules properly. Note: the CRD `scope` is manually changed to `Cluster` after code/YAML-generation. See: operator-framework/operator-sdk#1001
Using an unreleased version of `operator-sdk` which permits to build/run the operator outside of `GOPATH` using Go modules properly. Note: the CRD `scope` is manually changed to `Cluster` after code/YAML-generation. See: operator-framework/operator-sdk#1001
Using an unreleased version of `operator-sdk` which permits to build/run the operator outside of `GOPATH` using Go modules properly. Note: the CRD `scope` is manually changed to `Cluster` after code/YAML-generation. See: operator-framework/operator-sdk#1001
Using an unreleased version of `operator-sdk` which permits to build/run the operator outside of `GOPATH` using Go modules properly. Note: the CRD `scope` is manually changed to `Cluster` after code/YAML-generation. See: operator-framework/operator-sdk#1001
Using an unreleased version of `operator-sdk` which permits to build/run the operator outside of `GOPATH` using Go modules properly. Note: the CRD `scope` is manually changed to `Cluster` after code/YAML-generation. See: operator-framework/operator-sdk#1001
Using an unreleased version of `operator-sdk` which permits to build/run the operator outside of `GOPATH` using Go modules properly. Note: the CRD `scope` is manually changed to `Cluster` after code/YAML-generation. See: operator-framework/operator-sdk#1001
Description of the change: add go mod support by default for new operator projects with the option of using
dep
by setting--dep-manager=dep
.print-deps
will print dependencies of whichever dependency manager type is being used.Motivation for the change: see #992.