cmd/operator-sdk/olmcatalog: scaffold package.yaml for a set of… #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and the optional --csv-channel flag to specify in which channel an operator's CSV name should reside in their package manifest internal/pkg/scaffold/olm-catalog: PackageManifest scaffold adds and updates an <operatorname>.package.yaml file in deploy/olm-catalo/<operator-name>, a file used by OLM to manage operator CSV's
…ageManifest using app-operator.package.yaml
specify that c in --csv-channel=c is the package manifests' default channel internal/pkg/scaffold/olm-catalog/package_manifest*.go: add ChannelIsDefault field to PackageManifest scaffold to hold --default-channel value
estroz
added
kind/feature
estroz
requested review from
joelanford,
AlexNPavel,
lilic,
hasbro17 and
theishshah
openshift-ci-robot
added
the
size/L
jcrossley3
added a commit
to openshift-knative/knative-eventing-operator
that referenced
this pull request
May 7, 2019
Current gen-csv doesn't generate a valid package bundle because it doesn't create a package manifest. This should be fixed by operator-framework/operator-sdk#1364
joelanford
reviewed
May 28, 2019
joelanford
reviewed
May 29, 2019
joelanford
reviewed
May 31, 2019
|
@lilic @hasbro17 @AlexNPavel PTAL |
|
Update the CHANGELOG for the new flags |
hasbro17
reviewed
Jun 27, 2019
hasbro17
reviewed
Jun 27, 2019
Co-Authored-By: Haseeb Tariq <hasbro17@gmail.com>
Co-Authored-By: Haseeb Tariq <hasbro17@gmail.com>
hasbro17
reviewed
Jun 27, 2019
hasbro17
reviewed
Jun 27, 2019
hasbro17
reviewed
Jun 27, 2019
hasbro17
reviewed
Jun 27, 2019
hasbro17
reviewed
Jun 27, 2019
hasbro17
reviewed
Jun 27, 2019
hasbro17
approved these changes
Jun 27, 2019
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
estroz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
cmd/operator-sdk/olmcatalog/gen-csv.go: Added--csv-channelto add the CSV name with version supplied to--csv-versionto a package manifestdeploy/olm-catalog/operator-name/{operator_name}.package.yaml, and--default-channelto specify that the supplied channel is the default package manifest channel.internal/pkg/scaffold/olm-catalog/package_manifest*.go: Added aPackageManifestscaffold to create and update a package manifest file at the file location mentioned above.Motivation for the change: automatically creating and updating a package manifest for OLM users during CSV generation more easily onboards them.