-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the version of the dependency controller-runtime from v0.1.10
to v0.2.0-beta.1
#1388
Upgrade the version of the dependency controller-runtime from v0.1.10
to v0.2.0-beta.1
#1388
Conversation
Hi @camilamacedo86. Thanks for your PR. I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
v0.1.10
to v0.2.0-alpha.0
v0.1.10
to v0.2.0-alpha.0
v0.1.10
to v0.2.0-alpha.0
086034f
to
8cabd8f
Compare
8cabd8f
to
2f2910d
Compare
@camilamacedo86: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
699477e
to
146725c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @camilamacedo86 👋 there is already an open PR to migrate to that release of controller-runtim #1369 so maybe we can sync there to see the difference between the work and maybe somehow combine it? :)
Hi @lilic, I checked the PR #1369 made by @corinnekrych. This PR shows missing changes and because of it is not passing the ansible as well. Also, she increases the version of Kube. This one here, shows be working very well but the go test is facing timeout which I am not sure if is related or not to the changes made here. @lilic @corinnekrych let's combine the forces? I will try to check the changes made by you and apply here too and I'll ping you tomorrow for we check how we can move together. :-) NOTE:
|
I'd rather wait for a v0.2.0 stable release. There's no urgency to upgrade for the next release. |
/ok-to-test |
Sorry to hear that, but we can't have a nonstable release of such a huge dependency in our project, as we do promise certain stability to our users. @camilamacedo86 we discussed this and we want to wait until Wednesday at least, we will know when the stable controller-runtime release will happen and we will get back to you then. But we would be happy to have this contribution! |
A couple of things before this is ready to be merged:
cc @joelanford @theishshah @shawn-hurley @hasbro17 @AlexNPavel |
bfb46a5
to
a248060
Compare
a248060
to
d189e79
Compare
a301173
to
ab85994
Compare
Hi @estroz Really thank you for your help and support here. 👍 I rebase the commits in order to make easier we review and go forward as well. Also, I addressed all comments raised by you and I am working on in adding your changes and fixes from #1512 here. I understand that we need both, however, a direct merge/rebase will not work yet I will be solving/checking asap. |
9050db1
to
1caebb1
Compare
1caebb1
to
0a316ee
Compare
0a316ee
to
d41ad22
Compare
@camilamacedo86 #1512 already passes CI, so we should defer to that as the main bump PR. Thanks again for submitting this PR! We appreciate the urgency, as this is a big but necessary change. |
Hi @estroz if you could add there what was made here as well is great !!. |
@camilamacedo86: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description of the change:
Changed
v0.1.10
tov0.2.0-beta.1
kubernetes-1.13.1
tokubernetes-1.14.1
b8a4faf68e36feb6d99a6aec623b405e587b17b1
totag 0.10.1
0cf8f7e6ed1d2e3d47d02e3b6e559369af24d8
dependency to a01b7d5d6c2258c80a4a10070f3dee9cd575d9c7
Motivation for the change:
Address the commit kubernetes-sigs/controller-runtime@fc804a4
Progress
Working on in Rebase/Merge the changes/fixes from @estroz #1512