hack/tests/sanity-check.sh: ignore go.mod changes caused by go vet #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
/hold Until we have team consensus on the go1.13 migration plan outlined in the issue description. |
openshift-ci-robot
added
the
do-not-merge/hold
|
/test e2e-aws-helm |
1 similar comment
|
/test e2e-aws-helm |
|
/test e2e-aws-go |
joelanford
force-pushed
the
sanity-ignore-go-mod
branch
from
5021c16
to
d7edd9c
Compare
openshift-ci-robot
added
size/S
|
Rolled this into #1949, which helps it pass CI directly. We can merge #1949, then openshift/release#5443, then revert the sanity test changes once we're fully migrated to go1.13. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
This PR updates the sanity check script to ignore changes to go.mod caused by
go vet(and other go commands).Motivation for the change:
Many
gocommands change thego.modfile if it does not match what the go tooling expects.go.modfiles managed by go1.12 are changed when running go commands with go1.13. This causes problems with the sanity check script when trying to migrate from go1.12 to go1.13.During the transition, we can ignore
go.modfile changes that occur whengo vetruns earlier in the sanity check script. After the transition, we will revert this PR so that futurego.modfiles are checked for adherance to the go tooling expectations.Order of operations to complete go1.13 migration