Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set namespsace for metrics to WATCH_NAMESPACE #2078

Closed
wants to merge 1 commit into from
Closed

Set namespsace for metrics to WATCH_NAMESPACE #2078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/pkg/scaffold/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ func serveCRMetrics(cfg *rest.Config) error {
return err
}
// Get the namespace the operator is currently deployed in.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should update this comment too, since it's no longer accurate

operatorNs, err := k8sutil.GetOperatorNamespace()
operatorNs, err := k8sutil.GetWatchNamespace()
if err != nil {
return err
}
Expand Down
2 changes: 1 addition & 1 deletion internal/pkg/scaffold/cmd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ func serveCRMetrics(cfg *rest.Config) error {
return err
}
// Get the namespace the operator is currently deployed in.
operatorNs, err := k8sutil.GetOperatorNamespace()
operatorNs, err := k8sutil.GetWatchNamespace()
if err != nil {
return err
}
Expand Down