Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/.../gen-csv.go: set operatorName from config after CLI if empty #2297

Merged
merged 2 commits into from
Dec 6, 2019
Merged

cmd/.../gen-csv.go: set operatorName from config after CLI if empty #2297

merged 2 commits into from
Dec 6, 2019

Conversation

estroz
Copy link
Member

@estroz estroz commented Dec 5, 2019

Description of the change: set operatorName from config after checking if set via CLI.

Motivation for the change: fixes #2266.

Closes #2266

@estroz estroz added kind/bug Categorizes issue or PR as related to a bug. olm-integration Issue relates to the OLM integration labels Dec 5, 2019
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 5, 2019
@estroz estroz mentioned this pull request Dec 5, 2019
Closed
camilamacedo86
camilamacedo86 reviewed Dec 5, 2019
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit; missing CHANGELOG.
Also, would be nice to have added a test for that. Would it be possible?

@estroz
Copy link
Member Author

estroz commented Dec 5, 2019

@camilamacedo86 the bug and fix were straightforward so we do not need a test for this.

camilamacedo86
camilamacedo86 approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approved

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2019
@estroz estroz merged commit 3637f46 into operator-framework:master Dec 6, 2019
@estroz estroz deleted the bugfix/csv-respect-operator-name branch December 6, 2019 00:32
@aliok
Copy link
Contributor

aliok commented Dec 6, 2019

just gave it a try. works just fine.
Thanks for the fix people!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@jmrodri jmrodri Awaiting requested review from jmrodri

@joelanford joelanford Awaiting requested review from joelanford

@jmccormick2001 jmccormick2001 Awaiting requested review from jmccormick2001

@theishshah theishshah Awaiting requested review from theishshah

Assignees

@camilamacedo86 camilamacedo86

Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. olm-integration Issue relates to the OLM integration size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

operator-name in csv-config.yaml is ignored
4 participants
@estroz @aliok @camilamacedo86 @openshift-ci-robot