Remove k8s_status module, install from galaxy #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XL
openshift-ci-robot
added
needs-rebase
asmacdo
force-pushed
the
610-use-ansible-collection
branch
2 times, most recently
from
097da81
to
dab5a87
Compare
camilamacedo86
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
Just the @estroz nits
And then, /lgtm /approved for me as well 🥇
|
New changes are detected. LGTM label has been removed. |
openshift-ci-robot
added
the
needs-rebase
asmacdo
force-pushed
the
610-use-ansible-collection
branch
from
fad0802
to
3eb0c27
Compare
openshift-ci-robot
removed
the
needs-rebase
Co-Authored-By: Eric Stroczynski <estroczy@redhat.com>
asmacdo
force-pushed
the
610-use-ansible-collection
branch
from
3eb0c27
to
f1d15fb
Compare
joelanford
approved these changes
Dec 12, 2019
Comment on lines
+101
to
+102
| collections: | ||
| - operator_sdk.util` |
There was a problem hiding this comment.
Is there a best practice between declaring the collection like this and then using the shortened name in tasks vs using the fully qualified name in tasks?
There was a problem hiding this comment.
They don't seem to have a preference yet.
https://docs.ansible.com/ansible/devel/user_guide/collections_using.html#using-collections-in-a-playbook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.