Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/generate/gen: Config provides configuration for generators #2349

Closed
wants to merge 7 commits into from

Conversation

estroz
Copy link
Member

@estroz estroz commented Dec 19, 2019

Description of the change: Config is used to configure generators with input/output path info.

Motivation for the change: future generators will need configuration so they can run with different project structures.

Relates to #2201, #2328

Copy link
Contributor

@jmccormick2001 jmccormick2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 28, 2019
@estroz
Copy link
Member Author

estroz commented Jan 6, 2020

Closed by #2201.

@estroz estroz closed this Jan 6, 2020
@estroz estroz deleted the feature/gen-config branch April 1, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants