-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commands/operator-sdk/cmd/new: initialize git on new
#250
Conversation
I like it too. What do you think of adding a flag to disable it for the people who would use something else? |
added |
LGTM /cc @hasbro17 one thing: this now has an implicit dependence to git and that should be noted in the README |
I love that `cargo new` from the rust project initializes git after it creates my stock files. I don't have to run that command myself. Make `operator-sdk new` just call git init.
added git to list of prereqs in the user-guide. |
lgtm |
I don't think it's a good idea for We touched on this earlier but I don't think we decided to set the convention of enforcing the vendor dir to be committed. |
Users can still make that choice, although admittedly harder since they have to blow away the git commit, or use I'd argue that |
@eparis Fair enough. Committing the vendor does seem to have more benefits and it seems to be the standard for all kube projects as well. LGTM |
I love that
cargo new
from the rust project initializes git after it createsthe stock files. I don't have to run that command myself. Make
operator-sdk new
just call git init.