Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate csv: add empty spec.{icon,keywords,maintainers} for user discovery #2521

Merged
merged 5 commits into from
Feb 11, 2020
Merged

generate csv: add empty spec.{icon,keywords,maintainers} for user discovery #2521

merged 5 commits into from
Feb 11, 2020

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Feb 9, 2020 •
edited
Loading

Description

Screenshot 2020-02-09 at 01 40 27

Motivation

  • Very hard for the user found out how they suppose to fill it at the first tie ( I needed to look for them in the CSV files of the published operators in operatorhub.io when I did it for the first time )

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 9, 2020
@camilamacedo86 camilamacedo86 requested review from estroz, asmacdo, jmccormick2001 and jmrodri and removed request for shawn-hurley February 9, 2020 01:49
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 9, 2020
@camilamacedo86 camilamacedo86 changed the title add empty fields Add spec.Icon and spec.Mantainers empty by default to CSV generated by the tool Feb 9, 2020
estroz
estroz suggested changes Feb 10, 2020
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, a few changes needed first.

internal/scaffold/olm-catalog/csv.go Outdated Show resolved Hide resolved
internal/scaffold/olm-catalog/csv.go Outdated Show resolved Hide resolved
internal/scaffold/olm-catalog/csv.go Outdated Show resolved Hide resolved
internal/scaffold/olm-catalog/csv.go Outdated Show resolved Hide resolved
internal/scaffold/olm-catalog/csv.go Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 10, 2020
estroz
estroz reviewed Feb 11, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@camilamacedo86
Update CHANGELOG.md
68a8a55 
Co-Authored-By: Eric Stroczynski <estroczy@redhat.com>
@estroz estroz changed the title Add spec.Icon and spec.Mantainers empty by default to CSV generated by the tool generate csv: add empty spec.{icon,keywords,maintainers} for user discovery Feb 11, 2020
estroz
estroz approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2020
@camilamacedo86
Copy link
Contributor Author

It is very small and then, since @estroz, who has more expertise in this area approves I will move forward with.

@camilamacedo86 camilamacedo86 merged commit e0d9e45 into operator-framework:master Feb 11, 2020
@camilamacedo86 camilamacedo86 deleted the botton-icon branch February 11, 2020 15:38
camilamacedo86 added a commit to camilamacedo86/operator-sdk that referenced this pull request Feb 12, 2020
@camilamacedo86
generate csv: add empty spec.{icon,keywords,maintainers} for user (…
9726132 
…operator-framework#2521)

* scaffold csv with icon and mantainers specs
* add changelog

Co-authored-by: Eric Stroczynski <estroczy@redhat.com>
camilamacedo86 added a commit to camilamacedo86/operator-sdk that referenced this pull request Feb 12, 2020
@camilamacedo86
generate csv: add empty spec.{icon,keywords,maintainers} for user (…
d70a423 
…operator-framework#2521)

* scaffold csv with icon and mantainers specs
* add changelog

Co-authored-by: Eric Stroczynski <estroczy@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estroz estroz estroz approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@asmacdo asmacdo Awaiting requested review from asmacdo

@jmccormick2001 jmccormick2001 Awaiting requested review from jmccormick2001

@jmrodri jmrodri Awaiting requested review from jmrodri

Assignees

@estroz estroz

Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camilamacedo86 @estroz @openshift-ci-robot