Scaffold code in cmd/manager/main.go for Go operators and add logic to Ansible/Helm operators to handle [multinamespace caching]
#2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
camilamacedo86
force-pushed
the
add-multi
branch
3 times, most recently
from
8553e66
to
4bb3aa1
Compare
camilamacedo86
requested review from
estroz,
joelanford,
hasbro17,
jmccormick2001 and
asmacdo
estroz
suggested changes
Feb 10, 2020
There was a problem hiding this comment.
Overall a nice feature for users, needs work though.
@joelanford @fabianvf anything else we need to do for Helm/Ansible multinamespacing?
estroz
reviewed
Feb 10, 2020
openshift-ci-robot
added
size/M
camilamacedo86
commented
Feb 10, 2020
| @@ -6,6 +6,7 @@ | |||
| - Added `pkg/status` with several new types and interfaces that can be used in `Status` structs to simplify handling of [status conditions](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties). ([#1143](https://github.com/operator-framework/operator-sdk/pull/1143)) | |||
| - Added support for relative Ansible roles and playbooks paths in the Ansible operator's file. ([#2273](https://github.com/operator-framework/operator-sdk/pull/2273)) | |||
| - Add Prometheus metrics support to Ansible-based operators. ([#2179](https://github.com/operator-framework/operator-sdk/pull/2179)) | |||
| - Scaffold code in `cmd/manager/main.go` for Go operators and add logic to Ansible/Helm operators to handle [multinamespace caching](https://godoc.org/github.com/kubernetes-sigs/controller-runtime/pkg/cache#MultiNamespacedCacheBuilder) if `WATCH_NAMESPACE` contains multiple namespaces. ([#2522](https://github.com/operator-framework/operator-sdk/pull/2522)) | |||
|
|
|||
There was a problem hiding this comment.
Hi @dmesser have you any objection to solve the scenario with?
It is also related to the option targetNamespaces that allows MultiNamespace via the OperatorGroup.
Example:
targetNamespaces:
- ns1
- ns2
The scenario is described in #2361
Also, please see that it address common scenarios such as: #2494
c/c @joelanford
openshift-ci-robot
added
the
needs-rebase
camilamacedo86
changed the title
cmd/manager/main.go for Go operators and add logic to Ansible/Helm operators to handle [multinamespace caching]
camilamacedo86
force-pushed
the
add-multi
branch
from
b24aa8f
to
39ce485
Compare
openshift-ci-robot
removed
the
needs-rebase
dmesser
approved these changes
Feb 17, 2020
estroz
approved these changes
Feb 17, 2020
There was a problem hiding this comment.
/lgtm
Would like one more set of eyes on this first @hasbro17 @jmccormick2001.
jmccormick2001
approved these changes
Feb 17, 2020
hasbro17
reviewed
Feb 17, 2020
internal/scaffold/cmd.go
Outdated
| options.NewCache = cache.MultiNamespacedCacheBuilder(strings.Split(namespace, ",")) | ||
| } | ||
|
|
||
| // Create a new Cmd to provide shared dependencies and start components |
There was a problem hiding this comment.
Suggested change
| // Create a new Cmd to provide shared dependencies and start components | |
| // Create a new manager to provide shared dependencies and start components |
Whats Cmd?
hasbro17
approved these changes
Feb 17, 2020
internal/scaffold/cmd_test.go
Outdated
| options.NewCache = cache.MultiNamespacedCacheBuilder(strings.Split(namespace, ",")) | ||
| } | ||
|
|
||
| // Create a new Cmd to provide shared dependencies and start components |
There was a problem hiding this comment.
Suggested change
| // Create a new Cmd to provide shared dependencies and start components | |
| // Create a new manager to provide shared dependencies and start components |
pkg/ansible/run.go
Outdated
| options.Namespace = metav1.NamespaceAll | ||
| } | ||
|
|
||
| // Create a new Cmd to provide shared dependencies and start components |
There was a problem hiding this comment.
Suggested change
| // Create a new Cmd to provide shared dependencies and start components | |
| // Create a new manager to provide shared dependencies and start components |
|
New changes are detected. LGTM label has been removed. |
This was referenced Feb 27, 2020
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change:
Integration with OLM: See that OLM allows and config the MultiNamespace via the option
targetNamespacesvia the OperatorGroup. We are also in the olm commands setting these values in the WATCH-NAMESPACE EnvVar.Address the requirements requested in tasks such as Bug creating metric service monitors when watching a different namespace #2494, Set namespsace for metrics to WATCH_NAMESPACE #2078, (which are a very common scenario in the channels: I as an operator dev, would like to deploy the operator in the nsA and WATCH the resources in the nsB and do not all cluster ),
Closes #2361