-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated test.TestCtx in order to rename test.TestCtx to test.Context #2549
Deprecated test.TestCtx in order to rename test.TestCtx to test.Context #2549
Conversation
IMO, a name change because of a lint error is not sufficient reason to make a breaking change. I think this should be closed. |
7baad6e
to
1843786
Compare
@joelanford I agree, although this should have been |
fa0434d
to
f54d28e
Compare
Working on to apply @joe suggestion. |
f54d28e
to
df10d31
Compare
df10d31
to
840ba80
Compare
840ba80
to
6a04c80
Compare
Hi @joelanford it is following your suggestion now please let us know if you are ok with. |
e49109f
to
0a68018
Compare
Hi @estroz, I fund just one reference which was missing and it is fixed. Could you please check now? If you still find someplace that should be updated please, let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
0a68018
to
dfd33da
Compare
Unable to check this one.
Co-Authored-By: Eric Stroczynski <estroczy@redhat.com>
Co-Authored-By: Eric Stroczynski <estroczy@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description of the change:
test.TestCtx
in order to rename test.TestCtx to test.ContextMotivation for the change:
test.Test
;