Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test framework: handle double-registered --kubeconfig flag #2731

Merged

Commits on Mar 28, 2020

  1. controller-runtime currently adds the --kubeconfig flag if

    pkg/client/config is imported (set up in an init() function).
    The SDK's test framework also adds this flag, which will panic
    if both are imported and the test framework is initialized.
    This commit only registers --kubeconfig if it is not already
    registered, and gets its value if so.
    
    pkg/test: only register --kubeconfig if not registered, get value
    if already registered
    
    test/e2e: add import of controller-runtime/pkg/client/config to test --kubebuilder registration
    
    CHANGELOG.md: add --kubeconfig double registration fix
    estroz committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    f20560c View commit details
    Browse the repository at this point in the history