Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/generate/crd: change default CRD to v1 #2874

Merged
merged 1 commit into from
Apr 24, 2020
Merged

internal/generate/crd: change default CRD to v1 #2874

merged 1 commit into from
Apr 24, 2020

Conversation

joelanford
Copy link
Member

Description of the change:
Changed the default CRD version from apiextensions.k8s.io/v1beta1 to apiextensions.k8s.io/v1 for commands that create or generate CRDs.

Motivation for the change:
v1beta1 CRDs will be removed in Kubernetes v1.19, which is the next release. We need to help users start migrating from v1beta1 to v1 CRDs.

camilamacedo86
camilamacedo86 approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing in the CI I think it is safe to move forward.
Users can gen the beta if they need.

/lgtm
/approved

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2020
camilamacedo86
camilamacedo86 reviewed Apr 21, 2020
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

estroz
estroz approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@joelanford joelanford merged commit b17779d into operator-framework:master Apr 24, 2020
@joelanford joelanford deleted the crd-default-v1 branch April 24, 2020 13:52
@joelanford joelanford mentioned this pull request May 1, 2020
Closed
@Rulox Rulox mentioned this pull request Jul 30, 2020
Merged
zulh-civo added a commit to kubemart/kubemart-operator that referenced this pull request Mar 3, 2021
@zulh-civo
Changed the default CRD version from 'apiextensions.k8s.io/v1beta1' t…
02d762b 
…o 'apiextensions.k8s.io/v1'

* https://github.com/operator-framework/operator-sdk/blob/master/website/content/en/docs/upgrading-sdk-version/v0.18.0.md#default-crd-version
* operator-framework/operator-sdk#2874
* https://book.kubebuilder.io/reference/controller-gen.html#generators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@estroz estroz estroz approved these changes

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@camilamacedo86 camilamacedo86

@estroz estroz

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joelanford @camilamacedo86 @estroz @openshift-ci-robot