-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc/sdk-cli-reference: Adding details for up/local command. #290
Conversation
doc/sdk-cli-reference.md
Outdated
``` | ||
|
||
If you are planning on using a different namespace than the default, then you should use the namespace flag to change where the operator is watching for custom resources to be created. | ||
For this to work your operator must handle the `WATCH_NAMESPACE` environment variable. To do that you can use the [utility function](https://github.com/operator-framework/operator-sdk/blob/89bf021063d18b6769bdc551ed08fc37027939d5/pkg/util/k8sutil/k8sutil.go#L140) `k8sutil.GetWatchNamespace` in your operator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer to use [utility function][utility_link]
and provide
[utility_link]: https://github.com/operator-framework/operator-sdk/blob/89bf021063d18b6769bdc551ed08fc37027939d5/pkg/util/k8sutil/k8sutil.go#L140
at end of the file.
doc/sdk-cli-reference.md
Outdated
operator-sdk up local --operator-flags "--resync-interval 10" | ||
``` | ||
|
||
If you are planning on using a different namespace than the default, then you should use the namespace flag to change where the operator is watching for custom resources to be created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should use the namespace flag than the default
to
should use the --namespace flag than the default namespace
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fanminshi I'm sorry, but I am not following.
should use the namespace flag to change where the operator is watching for custom resources to be created.
Is this the part that you would like changed?
If it is I am not following this wording
If you are planning on using a different namespace than the default, then you should use the namespace flag than the default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the confustion, I meant
If you are planning on using a different namespace than the default, then you should use the namespace flag
->
If you are planning on using a different namespace than the default, then you should use the --namespace flag
lgtm after nits. |
fb7db7f
to
f236cbe
Compare
adds details and more examples for `operator-sdk up local` flags Fixes operator-framework#266
f236cbe
to
b11c0a5
Compare
adds details and more examples for
operator-sdk up local
flagsFixes #266