Add healthz liveness probe #2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmacdo
added
the
do-not-merge/work-in-progress
fabianvf
reviewed
Apr 28, 2020
Sets up a Ping healthz endpoint (ping) Adds a liveness probe to ansible operator deployment scaffolding
camilamacedo86
approved these changes
May 7, 2020
| but to take advantage of it, a liveness probe should be manually added | ||
| to the operator manifest. See the | ||
| [test operator](https://github.com/operator-framework/operator-sdk/blob/master/test/ansible/deploy/operator.yaml) | ||
| for an example. |
There was a problem hiding this comment.
By following the doc standard it would be as;
migration:
header: **(Optional for Ansible-base operators)** Add livenessProbe check
body: >
Existing operators will have a healthz endpoint without intervention,
but to take advantage of it, a liveness probe should be manually added
to the operator manifest. Add the livenessProbe as the following example in the`/deploy/operator.ymal`
```ymal
livenessProbe:
httpGet:
path: /healthz
port: 6789
initialDelaySeconds: 5
periodSeconds: 3
```
asmacdo
removed
the
do-not-merge/work-in-progress
jmrodri
approved these changes
May 8, 2020
Comment on lines
+111
to
+118
| live_pod=$(kubectl get pod -l name=memcached-operator -o jsonpath="{..metadata.name}") | ||
| if kubectl get events --field-selector involvedObject.name=$live_pod | grep Killing | ||
| then | ||
| error_text "FAIL: Operator pod killed due to failed liveness probe." | ||
| kubectl get events --field-selector involvedObject.name=$live_pod,reason=Killing | ||
| operator_logs | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Nice. I remember this discussion :) Looks like it worked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up a Ping healthz endpoint (ping)
Adds a liveness probe to ansible operator deployment scaffolding