Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/util/k8sutil: remove old MatchingFields helper #2957

Merged

Conversation

estroz
Copy link
Member

@estroz estroz commented May 2, 2020

Description of the change: remove MatchingFields in favor of controller-runtime's MatchingFieldsSelector.

Motivation for the change: should have been removed once kubernetes-sigs/controller-runtime#578 was merged.

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Good catcher.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2020
@jmccormick2001 jmccormick2001 self-requested a review May 4, 2020 13:28
@estroz estroz merged commit 3e920eb into operator-framework:master May 4, 2020
@estroz estroz deleted the chore/remove-matchingfields branch May 4, 2020 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants