Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.18.x] deps: bump api library for CRD validation bugfix #3167

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #3154

/assign estroz

Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estroz estroz merged commit 572e908 into operator-framework:v0.18.x Jun 3, 2020
Comment on lines +3 to +4
bump api validation library to 431198de9fc2cf82f369efb5c4a90a9cc079a1c3 to
fix "CRD key not found" validation bug.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO : It is not very clear to users. I'd recommend something as :

Suggested change
bump api validation library to 431198de9fc2cf82f369efb5c4a90a9cc079a1c3 to
fix "CRD key not found" validation bug.
fix the error "CRD key not found" faced when the command `bundle validation` is used via upgrading the module api validation used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a cherry-pick commit. We can add a link to the fixed issue in the v0.18.1 release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants