travis: Add rm of existing pkg dir #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasbro17
reviewed
Jun 25, 2018
.travis.yml
Outdated
| @@ -38,6 +38,7 @@ script: | |||
| - cd $GOPATH/src/github.com/example-inc | |||
| - operator-sdk new memcached-operator --api-version=cache.example.com/v1alpha1 --kind=Memcached | |||
| - cd memcached-operator | |||
| - rm -rf vendor/github.com/operator-framework/operator-sdk/pkg | |||
| - ln -sf ${TRAVIS_BUILD_DIR}/pkg vendor/github.com/operator-framework/operator-sdk/pkg | |||
There was a problem hiding this comment.
Remove the f flag since we don't need to overwrite pkg anymore.
|
LGTM after nit. |
This was referenced Jun 29, 2020
camilamacedo86
added a commit
that referenced
this pull request
Jul 7, 2020
…3305) **Description** - Just add the KB internal in internal/kubebuilder - change hack/check-license.sh to allow kb license **Motivation** SDK is in a process to be integrated with KB which means that its project layouts will be aligned. More info : [Integrating Kubebuilder and Operator SDK](https://github.com/kubernetes-sigs/kubebuilder/blob/master/designs/integrating-kubebuilder-and-osdk.md). As the first step, for we getting starting to working on in the Ansible/Helm plugins with the new layout we defined the strategy to just copy these helpers which will allow us to have the same features/utilities required to do the scaffolds. Note that these utilities are not exported by kubebuilder, in this way, since Ansible/Helm will be also plugins that will do similar scaffolds and following a similar design they will be useful in the next steps. For a further understanding see the WIP: #329 and the doc [Extensible CLI and Scaffolding Plugins](https://github.com/kubernetes-sigs/kubebuilder/blob/master/designs/extensible-cli-and-scaffolding-plugins-phase-1.md).
camilamacedo86
added a commit
that referenced
this pull request
Jul 15, 2020
**Description of the change:** This PR adds the helm plugin scaffolding the files with the new layout and using the current sdk helm pkg implementation (image) - added e2e tests for helm new layout. See:`/test/e2e-helm-new/e2e_suite.go` and `./hack/tests/e2e-helm-new.sh` - centralize the method ReplaceInFile in the test/internal/utils.go since it is useful for all tests - Impl e2e tests in shell for the new layout. See `hack/tests/e2e-helm.sh` **Motivation** SDK is in a process to be integrated with KB which means that its project layouts will be aligned. More info : [Integrating Kubebuilder and Operator SDK](https://github.com/kubernetes-sigs/kubebuilder/blob/master/designs/integrating-kubebuilder-and-osdk.md). This PR adds the Helm Plugin which will provide the Helm project in the new layout by the command `operator-sdk init --plugins=`helm.operator-sdk.io/v1`. For a further understanding see the WIP: #329 and the doc [Extensible CLI and Scaffolding Plugins](https://github.com/kubernetes-sigs/kubebuilder/blob/master/designs/extensible-cli-and-scaffolding-plugins-phase-1.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need to delete the existing vendored sdk pkg as the ln tool will not create the expected symlink over an existing directory.