-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: version upgrade guide: add more details for 0.11, 0.14, 0.16 #3307
docs: version upgrade guide: add more details for 0.11, 0.14, 0.16 #3307
Conversation
2fbf5b7
to
c7581b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit. Otherwise, I am ok with.
tks for your collab 👍
/lgtm
New changes are detected. LGTM label has been removed. |
05e9ea1
to
c6ca07e
Compare
- 0.11.x: sigs.k8s.io/controller-tools@v0.2.0 no longer has the package sigs.k8s.io/controller-tools/pkg/crd/generator - https://github.com/kubernetes-sigs/controller-tools/tree/v0.2.0/pkg/crd - 0.14.x: add details about the new function addMetrics() - 0.16.x: add details about multiple namespace support Co-authored-by: Camila Macedo <camilamacedo86@gmail.com> Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
c6ca07e
to
9a6a923
Compare
@camilamacedo86 I have made the changes suggested by you. |
Hi @bhavin192, We need + 1 ok before merge. @asmacdo @fabianvf @jmccormick2001 @jmrodri wdyt? Are you ok with these changes as well? |
Description of the change:
Motivation for the change:
Closes #3213