contrib: update release guide with helm/ansible operator and website info #3383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
requested review from
asmacdo,
camilamacedo86 and
varshaprasad96
openshift-ci-robot
added
the
kind/documentation
estroz
changed the title
| @@ -306,26 +330,17 @@ To github.com:operator-framework/operator-sdk.git | |||
|
|
|||
| Now that the branch exists, you need to make the post-release PR for the new release branch. To do this, simply follow the same steps as in [step 3](#3-create-a-pr-for-post-release-version-updates) with the addition of changing the branch name in the `go.mod` scaffold from `master` to the new branch (for example, `v1.3.x`). Then, make the PR against the new branch. | |||
|
|
|||
| ### 6. Updating the Homebrew formula | |||
There was a problem hiding this comment.
Should we not update the homebrew formula anymore?
|
The website-related steps are incorrect and need re-doing. Specifically, the release PR/tag need to include changes to /hold |
openshift-ci-robot
added
the
do-not-merge/hold
estroz
force-pushed
the
docs/update-release-guide
branch
from
1cec65a
to
51e76e1
Compare
asmacdo
approved these changes
Jul 14, 2020
| ```toml | ||
| [[params.versions]] | ||
| version = "v1.3" | ||
| url = "https://v1-3-x.sdk.operatorframework.io" |
There was a problem hiding this comment.
As mentioned above, this link won't work (and will fail CI) unless Netlify is already building this branch. The configuration on the netlify side cannot be done completely ahead of time though, the github branch must be created and pushed first.
I think if we add a git push here that should cover it.
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
estroz
force-pushed
the
docs/update-release-guide
branch
from
51e76e1
to
613e5af
Compare
…and ansible/helm operator release binaries
estroz
force-pushed
the
docs/update-release-guide
branch
2 times, most recently
from
613e5af
to
4af840c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change: new release steps are necessary to document.
/cc @asmacdo @camilamacedo86 @varshaprasad96
/kind documentation
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs