-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/test-framework: remove, and update/remove references and dependent tests #3424
test/test-framework: remove, and update/remove references and dependent tests #3424
Conversation
bd44a70
to
74d943c
Compare
hack/tests/integration.sh
Outdated
source hack/lib/image_lib.sh | ||
|
||
export OSDK_INTEGRATION_IMAGE="quay.io/example/memcached-operator:latest" | ||
TMPDIR="$(mktemp -d memcached-XXXX)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requires to be XXXX? Could not be a name related to the test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XXXX
is a template string which will be substituted with random characters. See mktemp -h
for more info.
6a498d4
to
f856b31
Compare
f856b31
to
117ba11
Compare
internal testing, and updates or removes any referent legacy tests. test/test-framework: remove *: remove references to the test-framework project or remove legacy tests using it
117ba11
to
e154026
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description of the change:
Motivation for the change: This PR removes the
test/test-framework
sample project used for internal testing, and updates or removes any referent legacy tests. This is part of a greater effort to remove legacy code to prepare for v1.0. See #3327 for details.Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs