-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/plugins: scaffold a vanilla go.kubebuilder.io/v2
project when --project-version=2
#3697
Merged
estroz
merged 2 commits into
operator-framework:master
from
estroz:bugfix/phase-2-scaffolds-project-version-2
Aug 8, 2020
Merged
internal/plugins: scaffold a vanilla go.kubebuilder.io/v2
project when --project-version=2
#3697
estroz
merged 2 commits into
operator-framework:master
from
estroz:bugfix/phase-2-scaffolds-project-version-2
Aug 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fig fields for project version 3+
go.kubebuilder.io/v2
project when --project-version=2
go.kubebuilder.io/v2
project when --project-version=2
/hold cancel |
Related to kubernetes-sigs/kubebuilder#1628 |
Closes #3674. |
768e776
to
d2623b1
Compare
/cc @shawn-hurley |
jmrodri
approved these changes
Aug 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
joelanford
approved these changes
Aug 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This was referenced Aug 8, 2020
estroz
added a commit
to estroz/operator-sdk
that referenced
this pull request
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change: only run phase 2 plugins for project versions >= 3-alpha.
Motivation for the change: The SDK should be scaffolding the vanilla
go.kubebuilder.io/v2
plugin if--project-version 2
is set, since thego.sdk.operatorframework.io
phase 2 plugin requires a 3-alpha project.Holding for discussion
/hold
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs