Gopkg.*,pkg/generator/templates.go: update to kubernetes 1.11.2 #391
Conversation
|
Not sure it if works. I can't get |
eparis
force-pushed
the
rebase-1.11
branch
4 times, most recently
from
8ae614f
to
02d378b
Compare
|
At the moment, we cannot use Kubernetes 1.11 in our CI, nor can we use minikube >= 0.26.0. The issue with minikube is reported here: kubernetes/minikube#2704. We could use |
eparis
force-pushed
the
rebase-1.11
branch
3 times, most recently
from
33be9ba
to
093bef4
Compare
|
@eparis I'm thinking we should hold off on updating to kubernetes-1.11.x at the moment. The SDK currently pins the revisions for the k8s dependencies by overriding them in the generated operator project: [[override]]
name = "k8s.io/client-go"
# revision for tag "kubernetes-1.11.2"
revision = "1f13a808da65775f22cbf47862c4e5898d8f4ca1"I expect that will cause problems when we try to vendor the controller-runtime which expects 1.10.1 tags. Plus the fact that we can't run our CI with a 1.11 cluster at the moment. |
|
I think that we will need to do this once the PRs for controller runtime are merged. and the master branch is based on 1.11 @eparis any chance you could rebase with master branch? |
|
@shawn-hurley We can update our k8s deps to 1.11 right now along with bumping up the controller-runtime dependency to In our CI minikube will have to stay at 0.26.0(k8s 1.10) @eparis Can you please also update other places where we've used the old discovery pkg. |
| # revision for tag "kubernetes-1.10.1" | ||
| revision = "989be4278f353e42f26c416c53757d16fcff77db" | ||
| # revision for tag "kubernetes-1.11.2" | ||
| revision = "1f13a808da65775f22cbf47862c4e5898d8f4ca1" | ||
|
|
||
| [[override]] | ||
| name = "sigs.k8s.io/controller-runtime" |
There was a problem hiding this comment.
Can you also update the controller-runtime version below to version = "v0.1.2".
There was a problem hiding this comment.
Turns out v0.1.3 is out. We can bump up to that since it comes with the leader election pkg.
| # revision for tag "kubernetes-1.10.1" | ||
| revision = "73d903622b7391f3312dcbac6483fed484e185f8" | ||
| # revision for tag "kubernetes-1.11.2" | ||
| revision = "2d6f90ab1293a1fb871cf149423ebb72aa7423aa" | ||
|
|
||
| [[override]] | ||
| name = "k8s.io/apiextensions-apiserver" |
There was a problem hiding this comment.
This should be bumped to 1.11.2 as well right?
| func GetKubeConfig() *rest.Config { | ||
| once.Do(newSingletonFactory) | ||
| return singletonFactory.kubeConfig | ||
| } |
There was a problem hiding this comment.
Let's not get rid of the core client and config just yet. At least not in this PR.
This was requested as an escape hatch from the sdk's generic client. #190
We'll rethink this through after the controller-runtime refactor.
|
not being able to import 1.11 is blocking me, okay if i continue this work in a new pr @eparis? |
|
Closing in favor of #522 |
No description provided.