Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-e2e/go : using samples #4056

Merged

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Oct 16, 2020

Description of the change:

  • Use Memcached sample instead of re-generate the project.
  • Fix/Adjust the e2e tests to work with the sample.

Motivation for the change:

operator-framework/enhancements#47

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2020
@camilamacedo86 camilamacedo86 changed the title WIP: Go e2e samples WIP: Use Go Memcached with webhooks sample into e2e Oct 16, 2020
@camilamacedo86 camilamacedo86 force-pushed the go-e2e-samples branch 4 times, most recently from eaeedc4 to f60941e Compare October 23, 2020 12:39
@camilamacedo86 camilamacedo86 force-pushed the go-e2e-samples branch 4 times, most recently from d4a96b1 to 6f54ab4 Compare October 24, 2020 15:09
@camilamacedo86 camilamacedo86 changed the title WIP: Use Go Memcached with webhooks sample into e2e Use Go Memcached with webhooks sample into e2e Oct 24, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2020
@camilamacedo86 camilamacedo86 added blocked area/testing Issue related to testing the operator-sdk and subcomponents labels Oct 24, 2020
@camilamacedo86 camilamacedo86 changed the title Use Go Memcached with webhooks sample into e2e WIP: Use Go Memcached with webhooks sample into e2e Oct 25, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2020
@camilamacedo86 camilamacedo86 force-pushed the go-e2e-samples branch 7 times, most recently from aefd928 to 839c239 Compare October 31, 2020 11:51
@camilamacedo86 camilamacedo86 changed the title WIP: Use Go Memcached with webhooks sample into e2e test-e2e/go : using samples Oct 31, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2020
@camilamacedo86 camilamacedo86 force-pushed the go-e2e-samples branch 2 times, most recently from ef5736d to ae873ce Compare December 8, 2020 10:12
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits

test/e2e-go/e2e_go_cluster_test.go Outdated Show resolved Hide resolved
test/e2e-go/e2e_go_olm_test.go Outdated Show resolved Hide resolved
test/e2e-go/e2e_go_olm_test.go Show resolved Hide resolved
test/e2e-go/e2e_go_olm_test.go Outdated Show resolved Hide resolved
test/e2e-go/e2e_go_olm_test.go Outdated Show resolved Hide resolved
test/e2e-go/e2e_go_olm_test.go Outdated Show resolved Hide resolved
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2020
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@camilamacedo86 camilamacedo86 merged commit 71c4019 into operator-framework:master Dec 8, 2020
@camilamacedo86 camilamacedo86 deleted the go-e2e-samples branch December 8, 2020 22:55
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
**Description of the change:**
- Use Memcached sample instead of re-generate the project.
- Fix/Adjust the e2e tests to work with the sample. 

**Motivation for the change:**

operator-framework/enhancements#47

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
rearl-scwx pushed a commit to rearl-scwx/operator-sdk that referenced this pull request Feb 5, 2021
**Description of the change:**
- Use Memcached sample instead of re-generate the project.
- Fix/Adjust the e2e tests to work with the sample. 

**Motivation for the change:**

operator-framework/enhancements#47

Signed-off-by: rearl <rearl@secureworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issue related to testing the operator-sdk and subcomponents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants