-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-e2e/go : using samples #4056
test-e2e/go : using samples #4056
Conversation
eaeedc4
to
f60941e
Compare
d4a96b1
to
6f54ab4
Compare
aefd928
to
839c239
Compare
e923be2
to
1c52f3e
Compare
ef5736d
to
ae873ce
Compare
ae873ce
to
39f078a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits
hack/generate/samples/internal/go/v3/memcached_with_webhooks.go
Outdated
Show resolved
Hide resolved
c40e587
to
2d4f3ec
Compare
2d4f3ec
to
e42334c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
**Description of the change:** - Use Memcached sample instead of re-generate the project. - Fix/Adjust the e2e tests to work with the sample. **Motivation for the change:** operator-framework/enhancements#47 Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
**Description of the change:** - Use Memcached sample instead of re-generate the project. - Fix/Adjust the e2e tests to work with the sample. **Motivation for the change:** operator-framework/enhancements#47 Signed-off-by: rearl <rearl@secureworks.com>
Description of the change:
Motivation for the change:
operator-framework/enhancements#47