Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible-operator,helm-operator: improve executable help text #4187

Merged
merged 5 commits into from
Nov 6, 2020
Merged

ansible-operator,helm-operator: improve executable help text #4187

merged 5 commits into from
Nov 6, 2020

Conversation

jberkhahn
Copy link
Contributor

Fixes #4106

@estroz

estroz
estroz suggested changes Nov 5, 2020
View reviewed changes
cmd/ansible-operator/main.go Outdated Show resolved Hide resolved
cmd/helm-operator/main.go Outdated Show resolved Hide resolved
jberkhahn and others added 2 commits November 5, 2020 11:15
@jberkhahn
Update cmd/helm-operator/main.go
b919e0f 
Co-authored-by: Eric Stroczynski <estroczy@redhat.com>
@jberkhahn
Update cmd/ansible-operator/main.go
bec5295 
Co-authored-by: Eric Stroczynski <estroczy@redhat.com>
@jberkhahn
Copy link
Contributor Author

@estroz updated

camilamacedo86
camilamacedo86 approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the fragment.
Otherwise, it shows ok for me 👍

@estroz
Copy link
Member

estroz commented Nov 5, 2020

@jberkhahn can you add a changelog fragment of kind: change that says something like

Improved ansible-operator and helm-operator binary help text

@jberkhahn
Copy link
Contributor Author

@estroz like this? never done one of these before, when should i and shouldn't i make one of these?

estroz
estroz approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! thanks

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2020
@estroz estroz changed the title add warning message to ansible-operator and helm-operator executables ansible-operator,helm-operator: improve executable help text Nov 6, 2020
@estroz estroz merged commit df23b7e into operator-framework:master Nov 6, 2020
@joelanford joelanford mentioned this pull request Nov 12, 2020
Open
10 tasks
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
@jberkhahn
ansible-operator,helm-operator: improve executable help text (operato…
853dfa9 
…r-framework#4187)

Co-authored-by: Eric Stroczynski <estroczy@redhat.com>
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford left review comments

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@estroz estroz estroz approved these changes

@marc-obrien marc-obrien Awaiting requested review from marc-obrien

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@estroz estroz

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify purpose of ansible-operator and helm-operator binaries
5 participants
@jberkhahn @estroz @joelanford @camilamacedo86 @openshift-ci-robot