internal/cmd: add build info metric in helm/ansible operators #4220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelanford
force-pushed
the
helm-ansible-version-metric
branch
from
1afcedf
to
9f308ed
Compare
joelanford
force-pushed
the
helm-ansible-version-metric
branch
from
9f308ed
to
dfc774c
Compare
10 tasks
estroz
approved these changes
Nov 23, 2020
| ) | ||
| ) | ||
|
|
||
| func RegisterBuildInfo(r prometheus.Registerer) { |
There was a problem hiding this comment.
@joelanford just a nit. Could you please add a comment here in this method before we get it merged?
Suggested change
| func RegisterBuildInfo(r prometheus.Registerer) { | |
| // RegisterBuildInfo ... | |
| func RegisterBuildInfo(r prometheus.Registerer) { |
There was a problem hiding this comment.
I'm going to go ahead and merge without these comments since CI already passed. If I push to this branch again, this PR will get stuck (we're currently out of Travis CI build credits).
|
@estroz I think the git commit hash is okay. Prometheus itself does this: https://www.robustperception.io/exposing-the-software-version-to-prometheus |
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
…or-framework#4220) Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
rearl-scwx
pushed a commit
to rearl-scwx/operator-sdk
that referenced
this pull request
Feb 5, 2021
…or-framework#4220) Signed-off-by: rearl <rearl@secureworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Added the
ansible_operator_build_infoandhelm_operator_build_infometrics to instrument commit and version information for the Ansible and Helm operators, respectively.Motivation for the change:
Expose runtime version information to augment stamp versions in bundle and CSV metadata.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs