pkg/sdk: Add label selector for sdk.Watch() #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial pass at adding label selector to watch
|
Can we document the update to the Watch interface in the user guide here |
|
@theishshah added some documentation and propose slight format change since we now have more than one option for watch. |
hasbro17
reviewed
Aug 27, 2018
doc/user-guide.md
Outdated
| ```Go | ||
| sdk.Watch("cache.example.com/v1alpha1", "Memcached", "default", 5, sdk.WithNumWorkers(n)) | ||
| ``` | ||
|
|
||
| **Label Selector** | ||
| Label selectors allow the watch to filter resources by kubernetes labels. It can be sepecified using the standard kubernetes label selector format: |
|
@CSdread Were you able to test this out to watch for CRs with a particular label? |
adding documentation
|
@hasbro17 it takes the k8s label selector format as its argument. It should handle what you would build in an operator to do the label selection. |
|
I will verify it tonight |
|
@theishshah I have validated that this works with a PoC. It works with multiple label selectors as well as per the Kube API: |
|
LGTM |
|
lgtm |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg/sdk: adding label selector to sdk.Watch()
This is being made because as of right now there is no way to watch a specific
sub-set of a resource based on labels. This makes implementing finalizer
controllers difficult.