Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: (helm) - if the release is not installed but status.DeployedRelease is populated, skip the rollback(uninstall) if the install errors #4297

Closed
wants to merge 1 commit into from
Closed

change: (helm) - if the release is not installed but status.DeployedRelease is populated, skip the rollback(uninstall) if the install errors #4297

wants to merge 1 commit into from

Conversation

mikeshng
Copy link
Contributor

@mikeshng mikeshng commented Dec 9, 2020 •
edited
Loading

Signed-off-by: Mike Ng ming@redhat.com

Description of the change:
If all the Helm release records are deleted, then the Helm operator will try to install the release again. In that case, if the install errors, then don't perform the uninstall rollback because it might lead to unintended data loss.

Motivation for the change:
In some rare cases, the Helm operator is performing an unintended Helm uninstall which can cause data loss. This change is to ensure that the Helm uninstall doesn't happen in those cases.

Closes: #4296

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@mikeshng mikeshng changed the title fix: (helm) - prevent a possible uninstall rollback if the release is incorrectly determined to be not installed WIP fix: (helm) - prevent a possible uninstall rollback if the release is incorrectly determined to be not installed Dec 10, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2020
@mikeshng mikeshng changed the title WIP fix: (helm) - prevent a possible uninstall rollback if the release is incorrectly determined to be not installed enh: (helm) - add a log when the helm storage is not in the usual expected state during the install path Dec 10, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2020
@mikeshng mikeshng changed the title enh: (helm) - add a log when the helm storage is not in the usual expected state during the install path change: (helm) - if the release is not installed but status.DeployedRelease is populated, skip the rollback(uninstall) if the install errors Dec 22, 2020
@mikeshng
change: (helm) - if the release is not installed but status.DeployedR…
f7b0f0f 
…elease is populated, skip the rollback(uninstall) if the install errors

Signed-off-by: Mike Ng <ming@redhat.com>
@mikeshng mikeshng mentioned this pull request Jan 11, 2021
Open
10 tasks
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 22, 2021
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 22, 2021
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this May 22, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 22, 2021

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@jmrodri jmrodri Awaiting requested review from jmrodri

Assignees
No one assigned
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm operator: in some rare cases, helm operator is incorrectly determining a release is not installed
3 participants
@mikeshng @openshift-bot @openshift-ci-robot