Bump controller-runtime to 0.7.0 #4306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
reviewed
Dec 11, 2020
go.mod
Outdated
| @@ -32,7 +32,7 @@ require ( | |||
| k8s.io/client-go v0.19.4 | |||
| k8s.io/kubectl v0.19.4 | |||
| rsc.io/letsencrypt v0.0.3 // indirect | |||
| sigs.k8s.io/controller-runtime v0.7.0-alpha.7 | |||
| sigs.k8s.io/controller-runtime v0.7.0 | |||
| sigs.k8s.io/controller-tools v0.3.0 | |||
There was a problem hiding this comment.
Suggested change
| sigs.k8s.io/controller-tools v0.3.0 | |
| sigs.k8s.io/controller-tools v0.4.1 |
|
@varshaprasad96 there are a bunch more changes needed that #4294 takes care of. You can either copy them over here or close this in favor of that one. Thoughts? |
varshaprasad96
force-pushed
the
bump/cr-0.7.0
branch
from
782c668
to
8bfe143
Compare
|
New changes are detected. LGTM label has been removed. |
* Bump controller-tools to 0.4.1 * Bump operator-framework/api to 0.4.0
varshaprasad96
force-pushed
the
bump/cr-0.7.0
branch
from
8bfe143
to
c3794ab
Compare
|
I can close this one, since this is just bumping the versions in go.mod. |
|
Thanks @estroz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Bump controller-runtime to 0.7.0
Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs