-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kube rbac proxy #4498
Merged
camilamacedo86
merged 5 commits into
operator-framework:master
from
camilamacedo86:fix-kube-rbac-proxy
Feb 10, 2021
Merged
Fix kube rbac proxy #4498
camilamacedo86
merged 5 commits into
operator-framework:master
from
camilamacedo86:fix-kube-rbac-proxy
Feb 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba4ae01
to
edee35e
Compare
estroz
suggested changes
Feb 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself is fine, but changelog fragment has formatting/information errors.
website/content/en/docs/building-operators/golang/references/logging.md
Outdated
Show resolved
Hide resolved
…0 to 0.8.0 Signed-off-by: Camila Macedo <cmacedo@redhat.com>
Co-authored-by: Eric Stroczynski <estroczy@redhat.com> Signed-off-by: Camila Macedo <cmacedo@redhat.com>
Co-authored-by: Eric Stroczynski <estroczy@redhat.com> Signed-off-by: Camila Macedo <cmacedo@redhat.com>
Co-authored-by: Eric Stroczynski <estroczy@redhat.com> Signed-off-by: Camila Macedo <cmacedo@redhat.com>
…ogging.md Co-authored-by: Eric Stroczynski <estroczy@redhat.com> Signed-off-by: Camila Macedo <cmacedo@redhat.com>
bca3e0d
to
8a53f69
Compare
estroz
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
kube-rbac-proxy
image version from0.5.0
to0.8.0
to address security concerns. More info #kubernetes-sigs/kubebuilder#1955.Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs