-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd: add build subcommand #49
Conversation
commands/operator-sdk/cmd/build.go
Outdated
This image will automatically set in the deployment manifests in output artifacts. | ||
|
||
After build completes, the image would be built locally in docker. Then it needs to | ||
be pushed to remote registry. For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe having For example:
to start in a new line?
...
For example:
...
commands/operator-sdk/cmd/build.go
Outdated
var buildCmd = &cobra.Command{ | ||
Use: "build <image>", | ||
Short: "Compiles code and builds artifacts", | ||
Long: `The operator-sdk build command compiles the code and builds the artifacts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how detail the command description needs to be. the termartifacts
might need a bit more descriptions either here or some other doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The artifacts in my mind is something produced in the software development process. It includes executables, documentation, deployment scripts, etc.
Let me think more about it if we want to say that right now.
I have made the description very explicit and clear so that it will give users a clear picture. |
lgtm defer to @hasbro17 |
commands/operator-sdk/cmd/build.go
Outdated
and generates Kubernetes manifests. | ||
|
||
<image> is the container image to be built, e.g. "quay.io/example/operator:v0.0.1". | ||
This image will automatically set in the deployment manifests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be automatically
LGTM after nit |
Fix paths in downstream dockerfile
No description provided.