Refactoring code for label-based filtering for Ansible Operators #5086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Venkat Ramaraju <venky2063@gmail.com>
VenkatRamaraju
force-pushed
the
Ansible-Selector
branch
from
65bfa7e
to
c8bb5f3
Compare
Signed-off-by: Venkat Ramaraju <venky2063@gmail.com>
estroz
reviewed
Aug 3, 2021
| return r.Selector.Matches(labels.Set(eventLabels)) | ||
| } | ||
|
|
||
| func NewResourceFilterPredicate(s metav1.LabelSelector) (predicate.Predicate, error) { |
There was a problem hiding this comment.
While the new LabelSelectorPredicate does not have the exact same implementation as this does, it seems like a safe change because labels should only be update-able from an update event.
bentito
pushed a commit
to bentito/operator-sdk
that referenced
this pull request
Aug 24, 2021
…rator-framework#5086) Signed-off-by: Venkat Ramaraju <venky2063@gmail.com>
twasyl
pushed a commit
to twasyl/operator-sdk
that referenced
this pull request
Sep 3, 2021
…rator-framework#5086) Signed-off-by: Venkat Ramaraju <venky2063@gmail.com> Signed-off-by: Thierry Wasylczenko <thierry.wasylczenko@gmail.com>
|
Fixes #4949 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Removed some of the code from #3275 and instead obtained the same functionality from controller runtime.
Motivation for the change:
When this was originally created in Operator SDK, controller-runtime did not support this feature. Now that it's a part of controller-runtime (from this PR), we leverage it in SDK and remove the extra code.
Notes
internal/ansible. The predicate folder only containspredicate.go. The code frompredicate.gois present upstream.