helm-operator: support go text/template evaluation in override values #5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelanford
added
kind/feature
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
force-pushed
the
helm-overrides-template
branch
from
ae3b978
to
c5b5c1d
Compare
|
Can you add a line or two about which text functions can be used to https://master.sdk.operatorframework.io/docs/building-operators/helm/reference/advanced_features/override_values/ |
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
force-pushed
the
helm-overrides-template
branch
from
9b929ee
to
1872173
Compare
|
New changes are detected. LGTM label has been removed. |
madorn
approved these changes
Aug 3, 2021
bentito
pushed a commit
to bentito/operator-sdk
that referenced
this pull request
Aug 24, 2021
…operator-framework#5105) * support go text/template evaluation in override values * add documentation for templating in helm override values Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
twasyl
pushed a commit
to twasyl/operator-sdk
that referenced
this pull request
Sep 3, 2021
…operator-framework#5105) * support go text/template evaluation in override values * add documentation for templating in helm override values Signed-off-by: Joe Lanford <joe.lanford@gmail.com> Signed-off-by: Thierry Wasylczenko <thierry.wasylczenko@gmail.com>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Support text/template expansion of helm-operator overrideValues.
Motivation for the change:
In some cases, environment variables need to be parsed to be used in helm charts, especially in dependent charts that helm-operator authors have less (or zero) control over.
For example, with this change it is possible to split a fully qualified image repo:tag into separate repo and tag values to pass to helm as values:
Environment:
Input values:
Expanded values:
/cc @madorn
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs