-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(generate): exclude ServiceAccounts in the CSV from generated bundle #5120
Conversation
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
/cc @joelanford |
/cherry-pick v1.10.x |
@estroz: once the present PR merges, I will cherry-pick it on top of v1.10.x in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick v1.9.x |
@estroz: once the present PR merges, I will cherry-pick it on top of v1.9.x in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Because we're releasing v1.8.2 anyway /cherry-pick v1.8.x |
@estroz: once the present PR merges, I will cherry-pick it on top of v1.8.x in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -31,23 +31,6 @@ func GetManifestObjects(c *collector.Manifests, extraSAs []string) (objs []clien | |||
objs = append(objs, &c.V1beta1CustomResourceDefinitions[i]) | |||
} | |||
|
|||
// All ServiceAccounts passed in should be written. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this do anything useful or was it just broken behavior from the beginning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broken behavior, based on incorrect assumptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@estroz: new pull request created: #5124 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@estroz: #5120 failed to apply on top of branch "v1.9.x":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@estroz: #5120 failed to apply on top of branch "v1.8.x":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…le (operator-framework#5120) Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
…le (operator-framework#5120) Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
…le (operator-framework#5120) Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
…le (operator-framework#5120) Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com> Signed-off-by: Thierry Wasylczenko <thierry.wasylczenko@gmail.com>
Description of the change: exclude ServiceAccounts in the CSV from generated bundle dir.
Motivation for the change: since OLM owns ServiceAccounts specified in a CSV but will create any in a bundle, those already in a CSV should not be also included in a bundle. See #5119 for details.
/kind bug
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs