-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update k8s 1.22 #5228
update k8s 1.22 #5228
Conversation
@@ -40,7 +40,6 @@ operator-sdk create webhook [flags] | |||
--plural string resource irregular plural form | |||
--programmatic-validation if set, scaffold the validating webhook | |||
--version string resource Version | |||
--webhook-version string version of {Mutating,Validating}WebhookConfigurations to scaffold. Options: [v1, v1beta1] (default "v1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flag was marked as deprecated and because of this the generate doc is removing when ihmo should not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we do remove deprecated flags from the docs, right? Do we still need to have this since officially go/v3 still supports v1beta1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs are generated automatically (see: https://github.com/operator-framework/operator-sdk/blob/master/Makefile#L42). Then, we need to change/fix that. See: #5286
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camilamacedo86 This scares me. We're removing a flag which technically is NOT backwards compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sigh, I just now read all of the comments.
@@ -47,7 +50,6 @@ operator-sdk create api [flags] | |||
|
|||
``` | |||
--controller if set, generate the controller without prompting the user (default true) | |||
--crd-version string version of CustomResourceDefinition to scaffold. Options: [v1, v1beta1] (default "v1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flag was marked as deprecated and because of this the generate doc is removing when ihmo should not
3fd326c
to
f330e5c
Compare
4208de9
to
e103eee
Compare
de39e48
to
faf51a7
Compare
b2fc215
to
51450ad
Compare
/hold cancel It is go to be reviewed and merged now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR Camila, this is really helpful. Just a few nits, else /lgtm
@@ -40,7 +40,6 @@ operator-sdk create webhook [flags] | |||
--plural string resource irregular plural form | |||
--programmatic-validation if set, scaffold the validating webhook | |||
--version string resource Version | |||
--webhook-version string version of {Mutating,Validating}WebhookConfigurations to scaffold. Options: [v1, v1beta1] (default "v1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we do remove deprecated flags from the docs, right? Do we still need to have this since officially go/v3 still supports v1beta1?
73a9dd0
to
33c6aca
Compare
hi @varshaprasad96,
The docs are generated automatically (see: https://github.com/operator-framework/operator-sdk/blob/master/Makefile#L42). Then, we need to change/fix that. See: #5286 |
33c6aca
to
c3bd26a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog has a couple typos and I reworded some of the migration snippet. The rest of the PR looks fine.
changelog/fragments/bump-1.22.yaml
Outdated
migration: | ||
header: Upgrade K8s versions to use 1.22 (golang/v3) | ||
body: > | ||
Note that to ensure the backwords compatibility SDK tool will try to downgrade the versions used if you need to still scaffold the v1beta1 for CRDs and Webhooks to pusblish your solutions into the old cluster versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that to ensure the backwords compatibility SDK tool will try to downgrade the versions used if you need to still scaffold the v1beta1 for CRDs and Webhooks to pusblish your solutions into the old cluster versions. | |
Note that to ensure the backwards compatibility SDK tool will try to downgrade the versions used if you need to still scaffold the v1beta1 for CRDs and Webhooks to publish your solutions into older cluster versions. |
changelog/fragments/bump-1.22.yaml
Outdated
sigs.k8s.io/controller-runtime v0.10.0 | ||
``` | ||
|
||
2) Update your Makafile by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2) Update your Makafile by | |
2) Update your Makefile by |
…en and controller-runtime Signed-off-by: Camila Macedo <cmacedo@redhat.com>
Signed-off-by: Camila Macedo <cmacedo@redhat.com>
ed83e96
to
fffcdb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Camila Macedo <cmacedo@redhat.com>
fffcdb9
to
167f15c
Compare
New changes are detected. LGTM label has been removed. |
Description
1.21
to1.22
.v0.6.2
tov0.7.0
. More info: https://github.com/kubernetes-sigs/controller-tools/releasesv0.9.2
tov0.10.0
. More info: https://github.com/kubernetes-sigs/controller-runtime/releases1.21
to1.22
.