update k8s 1.22 #5228

camilamacedo86 · 2021-09-20T23:43:33Z

Description

Upgrade the Kubernetes dependencies from 1.21 to 1.22.
Upgrade the controller-gen dependency from v0.6.2 to v0.7.0. More info: https://github.com/kubernetes-sigs/controller-tools/releases
Upgrade the sigs.k8s.io/controller-runtime dependency from v0.9.2 to v0.10.0. More info: https://github.com/kubernetes-sigs/controller-runtime/releases
Upgrade the Env Test used from 1.21 to 1.22.

camilamacedo86 · 2021-09-20T23:45:34Z

website/content/en/docs/cli/operator-sdk_create_webhook.md

@@ -40,7 +40,6 @@ operator-sdk create webhook [flags]
      --plural string             resource irregular plural form
      --programmatic-validation   if set, scaffold the validating webhook
      --version string            resource Version
-      --webhook-version string    version of {Mutating,Validating}WebhookConfigurations to scaffold. Options: [v1, v1beta1] (default "v1")


The flag was marked as deprecated and because of this the generate doc is removing when ihmo should not

But we do remove deprecated flags from the docs, right? Do we still need to have this since officially go/v3 still supports v1beta1?

The docs are generated automatically (see: https://github.com/operator-framework/operator-sdk/blob/master/Makefile#L42). Then, we need to change/fix that. See: #5286

@camilamacedo86 This scares me. We're removing a flag which technically is NOT backwards compatible.

Sigh, I just now read all of the comments.

camilamacedo86 · 2021-09-20T23:45:38Z

website/content/en/docs/cli/operator-sdk_create_api.md

@@ -47,7 +50,6 @@ operator-sdk create api [flags]

 ```
      --controller           if set, generate the controller without prompting the user (default true)
-      --crd-version string   version of CustomResourceDefinition to scaffold. Options: [v1, v1beta1] (default "v1")


The flag was marked as deprecated and because of this the generate doc is removing when ihmo should not

go.mod

camilamacedo86 · 2021-10-02T11:57:34Z

/hold cancel

It is go to be reviewed and merged now 👍

varshaprasad96

Thanks for the PR Camila, this is really helpful. Just a few nits, else /lgtm

varshaprasad96 · 2021-10-06T03:14:12Z

website/content/en/docs/cli/operator-sdk_create_webhook.md

@@ -40,7 +40,6 @@ operator-sdk create webhook [flags]
      --plural string             resource irregular plural form
      --programmatic-validation   if set, scaffold the validating webhook
      --version string            resource Version
-      --webhook-version string    version of {Mutating,Validating}WebhookConfigurations to scaffold. Options: [v1, v1beta1] (default "v1")


But we do remove deprecated flags from the docs, right? Do we still need to have this since officially go/v3 still supports v1beta1?

changelog/fragments/bump-1.22.yaml

camilamacedo86 · 2021-10-06T13:21:14Z

hi @varshaprasad96,

But we do remove deprecated flags from the docs, right? Do we still need to have this since officially go/v3 still supports v1beta1?

The docs are generated automatically (see: https://github.com/operator-framework/operator-sdk/blob/master/Makefile#L42). Then, we need to change/fix that. See: #5286

jmrodri

The changelog has a couple typos and I reworded some of the migration snippet. The rest of the PR looks fine.

jmrodri · 2021-10-12T17:44:23Z

changelog/fragments/bump-1.22.yaml

+    migration:
+      header: Upgrade K8s versions to use 1.22 (golang/v3)
+      body: >
+        Note that to ensure the backwords compatibility SDK tool will try to downgrade the versions used if you need to still scaffold the v1beta1 for CRDs and Webhooks to pusblish your solutions into the old cluster versions.


Suggested change

Note that to ensure the backwords compatibility SDK tool will try to downgrade the versions used if you need to still scaffold the v1beta1 for CRDs and Webhooks to pusblish your solutions into the old cluster versions.

Note that to ensure the backwards compatibility SDK tool will try to downgrade the versions used if you need to still scaffold the v1beta1 for CRDs and Webhooks to publish your solutions into older cluster versions.

jmrodri · 2021-10-12T17:46:17Z

changelog/fragments/bump-1.22.yaml

+        sigs.k8s.io/controller-runtime v0.10.0
+        ```
+
+        2) Update your Makafile by


Suggested change

2) Update your Makafile by

2) Update your Makefile by

changelog/fragments/bump-1.22.yaml

…en and controller-runtime Signed-off-by: Camila Macedo <cmacedo@redhat.com>

Signed-off-by: Camila Macedo <cmacedo@redhat.com>

jmrodri

/lgtm

Signed-off-by: Camila Macedo <cmacedo@redhat.com>

openshift-ci · 2021-10-12T21:38:06Z

New changes are detected. LGTM label has been removed.

camilamacedo86 requested a review from varshaprasad96 September 20, 2021 23:43

openshift-ci bot requested review from fabianvf and joelanford September 20, 2021 23:43

camilamacedo86 commented Sep 20, 2021

View reviewed changes

camilamacedo86 force-pushed the sdk-update branch from 3fd326c to f330e5c Compare September 20, 2021 23:46

camilamacedo86 commented Sep 20, 2021

View reviewed changes

go.mod Outdated Show resolved Hide resolved

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2021

camilamacedo86 force-pushed the sdk-update branch 3 times, most recently from 4208de9 to e103eee Compare September 21, 2021 01:26

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 21, 2021

camilamacedo86 force-pushed the sdk-update branch from de39e48 to faf51a7 Compare September 22, 2021 10:13

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2021

camilamacedo86 force-pushed the sdk-update branch 5 times, most recently from b2fc215 to 51450ad Compare October 2, 2021 11:57

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2021

camilamacedo86 requested a review from jmrodri October 4, 2021 20:11

varshaprasad96 approved these changes Oct 6, 2021

View reviewed changes

camilamacedo86 force-pushed the sdk-update branch from 73a9dd0 to 33c6aca Compare October 6, 2021 08:37

camilamacedo86 force-pushed the sdk-update branch from 33c6aca to c3bd26a Compare October 6, 2021 13:25

jmrodri requested changes Oct 12, 2021

View reviewed changes

Camila Macedo added 2 commits October 12, 2021 22:13

bump kb and update to use k8s 1.22 and upper versions of controller-g…

0037b99

…en and controller-runtime Signed-off-by: Camila Macedo <cmacedo@redhat.com>

address suggestions nits

3381dd8

Signed-off-by: Camila Macedo <cmacedo@redhat.com>

camilamacedo86 force-pushed the sdk-update branch from ed83e96 to fffcdb9 Compare October 12, 2021 21:16

camilamacedo86 requested a review from jmrodri October 12, 2021 21:16

jmrodri approved these changes Oct 12, 2021

View reviewed changes

openshift-ci bot assigned jmrodri Oct 12, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2021

nit suggestions

167f15c

Signed-off-by: Camila Macedo <cmacedo@redhat.com>

camilamacedo86 force-pushed the sdk-update branch from fffcdb9 to 167f15c Compare October 12, 2021 21:38

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2021

camilamacedo86 merged commit acbc148 into operator-framework:master Oct 12, 2021

camilamacedo86 deleted the sdk-update branch October 12, 2021 22:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update k8s 1.22 #5228

update k8s 1.22 #5228

camilamacedo86 commented Sep 20, 2021 •

edited

Loading

camilamacedo86 Sep 20, 2021

varshaprasad96 Oct 6, 2021

camilamacedo86 Oct 6, 2021

jmrodri Oct 12, 2021

jmrodri Oct 12, 2021

camilamacedo86 Sep 20, 2021

camilamacedo86 commented Oct 2, 2021 •

edited

Loading

varshaprasad96 left a comment

varshaprasad96 Oct 6, 2021

camilamacedo86 commented Oct 6, 2021

jmrodri left a comment

jmrodri Oct 12, 2021

jmrodri Oct 12, 2021

jmrodri left a comment

openshift-ci bot commented Oct 12, 2021

	Note that to ensure the backwords compatibility SDK tool will try to downgrade the versions used if you need to still scaffold the v1beta1 for CRDs and Webhooks to pusblish your solutions into the old cluster versions.
	Note that to ensure the backwards compatibility SDK tool will try to downgrade the versions used if you need to still scaffold the v1beta1 for CRDs and Webhooks to publish your solutions into older cluster versions.

update k8s 1.22 #5228

update k8s 1.22 #5228

Conversation

camilamacedo86 commented Sep 20, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

camilamacedo86 commented Oct 2, 2021 • edited Loading

varshaprasad96 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

camilamacedo86 commented Oct 6, 2021

jmrodri left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmrodri left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Oct 12, 2021

camilamacedo86 commented Sep 20, 2021 •

edited

Loading

camilamacedo86 commented Oct 2, 2021 •

edited

Loading