Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ansible collections community.kubernetes to kubernetes.core #5249

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Bump ansible collections community.kubernetes to kubernetes.core #5249

merged 1 commit into from
Oct 15, 2021

Conversation

VenkatRamaraju
Copy link
Contributor

@VenkatRamaraju VenkatRamaraju commented Sep 28, 2021 •
edited
Loading

Description of the change:
Replaced instances of community.kubernetes with kubernetes.core in scaffolding, tests, and docs.
Left community.kubernetes in requirements.go.

Motivation for the change:
Close #5227.

@VenkatRamaraju VenkatRamaraju force-pushed the bump-collections branch 12 times, most recently from a1689cf to 8f3dc51 Compare September 29, 2021 18:06
asmacdo
asmacdo reviewed Sep 29, 2021
View reviewed changes
website/content/en/docs/upgrading-sdk-version/v1.6.0.md Outdated
@@ -50,7 +50,7 @@ _See [#4701](https://github.com/operator-framework/operator-sdk/pull/4701) for m

## (ansible/v1) Update Ansible collections

In your requirements.yml, change the `version` field for community.kubernetes to `1.2.1`, and the `version` field for `operator_sdk.util` to `0.2.0`.
In your requirements.yml, change the `version` field for kubernetes.core to `1.2.1`, and the `version` field for `operator_sdk.util` to `0.2.0`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually you can revert the changes to the previous migration/upgrade docs. Since they are historical they are correct.

asmacdo
asmacdo reviewed Sep 29, 2021
View reviewed changes
website/content/en/docs/upgrading-sdk-version/version-upgrade-guide.md Outdated
@@ -1219,11 +1219,11 @@ By default the full Ansible logs will not be output, however, you can setup it v

**Migration to Ansible collections**

The core Ansible Kubernetes modules have been moved to the [`community.kubernetes` Ansible collection][kubernetes-ansible-collection]. Future development of the modules will occur there, with only critical bugfixes going into the modules in core. Additionally, the `operator_sdk.util` collection is no longer installed by default in the base image. Instead, users should add a `requirements.yml` to their project root, with the following content:
The core Ansible Kubernetes modules have been moved to the [`kubernetes.core` Ansible collection][kubernetes-ansible-collection]. Future development of the modules will occur there, with only critical bugfixes going into the modules in core. Additionally, the `operator_sdk.util` collection is no longer installed by default in the base image. Instead, users should add a `requirements.yml` to their project root, with the following content:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be reverted too

@VenkatRamaraju VenkatRamaraju force-pushed the bump-collections branch 6 times, most recently from c1bcd05 to 244b407 Compare September 30, 2021 16:08
asmacdo
asmacdo approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@asmacdo asmacdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more docs change to revert, otherwise LGTM. I dont need to rereview after you make that change

changelog/generated/v1.6.1.md Outdated Show resolved Hide resolved
website/content/en/docs/upgrading-sdk-version/v1.6.1.md Outdated Show resolved Hide resolved
fabianvf
fabianvf suggested changes Sep 30, 2021
View reviewed changes
Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need change log fragment with migration instructions (just adding new collection to requirement file)

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2021
@VenkatRamaraju VenkatRamaraju force-pushed the bump-collections branch 2 times, most recently from ad90c54 to 2fe97cb Compare October 1, 2021 16:56
fabianvf
fabianvf reviewed Oct 1, 2021
View reviewed changes
changelog/fragments/bump-ansible-collections.yaml
# the migration guide. This is required for breaking changes.
migration:
header: Update ansible collection ``community.kubernetes`` and the openshift Python version
body: >
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The body should be instructions for how to incorporate the changes to their operator, ie, what content to they need to add to which files to get the new behavior

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabianvf made those changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VenkatRamaraju you want to get real specific in the migration instructions, like exactly the content that needs to change in the exact files to bring them in line

@jobcespedes jobcespedes mentioned this pull request Oct 3, 2021
Open
@VenkatRamaraju VenkatRamaraju force-pushed the bump-collections branch 2 times, most recently from 78c5edd to 6bb2c45 Compare October 8, 2021 17:44
@VenkatRamaraju
replaced instances
f99e3e7 
Signed-off-by: Venkat Ramaraju <venky2063@gmail.com>
fabianvf
fabianvf approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2021
@jmrodri jmrodri merged commit ff54fb4 into operator-framework:master Oct 15, 2021
theishshah pushed a commit to theishshah/operator-sdk that referenced this pull request Oct 27, 2021
@VenkatRamaraju
replaced instances (operator-framework#5249)
9453be8 
Signed-off-by: Venkat Ramaraju <venky2063@gmail.com>
Signed-off-by: Ish Shah <ishah@redhat.com>
fao89 added a commit to fao89/pulp-operator that referenced this pull request Oct 28, 2021
@fao89
Bump ansible collections community.kubernetes to kubernetes.core
159048d 
ref: operator-framework/operator-sdk#5249

[noissue]
@fao89 fao89 mentioned this pull request Oct 28, 2021
Merged
fao89 added a commit to fao89/pulp-operator that referenced this pull request Oct 28, 2021
@fao89
Bump ansible collections community.kubernetes to kubernetes.core
72d99c0 
ref: operator-framework/operator-sdk#5249

[noissue]
fao89 added a commit to fao89/pulp-operator that referenced this pull request Oct 28, 2021
@fao89
Bump ansible collections community.kubernetes to kubernetes.core
147e3e1 
ref: operator-framework/operator-sdk#5249

[noissue]
fao89 added a commit to fao89/pulp-operator that referenced this pull request Oct 28, 2021
@fao89
Bump ansible collections community.kubernetes to kubernetes.core
3bd8c55 
ref: operator-framework/operator-sdk#5249

[noissue]
fao89 added a commit to fao89/pulp-operator that referenced this pull request Oct 29, 2021
@fao89
Bump ansible collections community.kubernetes to kubernetes.core
ef6949e 
ref: operator-framework/operator-sdk#5249

[noissue]
fao89 added a commit to pulp/pulp-operator that referenced this pull request Oct 29, 2021
@fao89
Bump ansible collections community.kubernetes to kubernetes.core
15ff05d 
ref: operator-framework/operator-sdk#5249

[noissue]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmacdo asmacdo asmacdo approved these changes

@fabianvf fabianvf fabianvf approved these changes

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@fabianvf fabianvf

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bump ansible collections community.kubernetes to kubernetes.core
4 participants
@VenkatRamaraju @asmacdo @fabianvf @jmrodri