-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Helm diffs output for "info" zap log level #5307
Remove Helm diffs output for "info" zap log level #5307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the commit message to be similar to your description comment. Also, if you include Closes #5278
in the commit message, then that issue will be closed automatically when this PR merges.
# release notes and/or the migration guide | ||
entries: | ||
- description: > | ||
Helm operators will now not display the reconciliaton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine as-is, but in the interest of being as concise and clear as possible, IMO it is best to say what the behavior is, rather than what it is not.
"Helm operator reconciliation diffs are now logged only at the debug level."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asmacdo Cool, just did all the above.
…r release diffs Signed-off-by: Venkat Ramaraju <venky2063@gmail.com>
0f3ddf2
to
a14a3e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description of the change:
Increased the verbosity threshold so that reconciliation diffs for Helm is not displayed when zap log level is set to "info."
Motivation for the change:
Close #5278
Notes