Add related images to bundle generation #5519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan King <ryking@redhat.com>
jmrodri
reviewed
Jan 26, 2022
internal/generate/clusterserviceversion/clusterserviceversion.go
Outdated
Show resolved
Hide resolved
theishshah
approved these changes
Jan 26, 2022
Signed-off-by: Ryan King <ryking@redhat.com>
Signed-off-by: Ryan King <ryking@redhat.com>
|
/lgtm |
Signed-off-by: Ryan King <ryking@redhat.com>
|
/lgtm |
ryantking
added a commit
that referenced
this pull request
Feb 23, 2022
* add related images to bundle generation Signed-off-by: Ryan King <ryking@redhat.com> * regenerate and fix typos Signed-off-by: Ryan King <ryking@redhat.com> * no related images will be null, not an empty slice Signed-off-by: Ryan King <ryking@redhat.com> * regenerate to fix sanity Signed-off-by: Ryan King <ryking@redhat.com>
jmrodri
pushed a commit
that referenced
this pull request
Feb 25, 2022
* add related images to bundle generation Signed-off-by: Ryan King <ryking@redhat.com> * regenerate and fix typos Signed-off-by: Ryan King <ryking@redhat.com> * no related images will be null, not an empty slice Signed-off-by: Ryan King <ryking@redhat.com> * regenerate to fix sanity Signed-off-by: Ryan King <ryking@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan King ryking@redhat.com
Description of the change:
During bundle generation (
operator-sdk generate bundleormake bundle),operator-sdkwill look through the environment of the controller manager for related images, namedRELATED_IMAGE_<IMAGE_NAME>, and add them to theClusterServiceVersionspec.relatedImagesfield.Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs