-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for external bundle validators #5525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few questions/suggestions
872c49e
to
d597916
Compare
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
Signed-off-by: jesus m. rodriguez <jesusr@redhat.com>
51d627b
to
e7d71cc
Compare
The PrintWithFormat method would hard exit if there was an error in the test. Instead of returning a special error for this case, we added a boolean to indicate if there is a failed result. This allows the cmd to handle this case and we no longer have a hard exit in the middle of a library function. Signed-off-by: jesus m. rodriguez <jmrodri@gmail.com>
Signed-off-by: jesus m. rodriguez <jmrodri@gmail.com>
Signed-off-by: jesus m. rodriguez <jmrodri@gmail.com>
e7d71cc
to
89cd7e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit. Everything else looks good to me.
I don't think it should block it from merging if you don't think the change is necessary so I am not requesting changes. Since I am still learning the ropes I will leave explicit approval to someone else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me. I am approving and will leave it up to you whether or not you want to wait for another approval before merging.
Description of the change:
Adding support for external bundle validators.
Motivation for the change:
Today whenever there are validation changes specific to OpenShift, that often trickles to the upstream release. By adding external bundle validator support, this can allow bundle validator authors to create external binaries to be called by operator-sdk and allow business specific validators to not impact upstream releases.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs