Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping OPM version from v1.19.1 to v1.21.0 (one of its motivations is to provide support for ppc64le and s390x arches) #5676

Conversation

aemperador
Copy link
Contributor

Description of the change:
Bump OPM version to 1.21.0 from 1.19.1 to support ppc64le and s390x arches

Motivation for the change:
Need support for ppc64le and s390x for official support

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@gquillar
Copy link

Change in testdata/ansible/memcached-operator/Makefile is missing

@aemperador
Copy link
Contributor Author

thanks, @gquillar for the catch. added the missing update

@aemperador
Copy link
Contributor Author

@asmacdo or @theishshah could I get a review on this PR? thank you!

@aemperador aemperador changed the title Bump OPM Version to 1.21.0 to support ppc64le and s390x arches Bumping OPM version from v1.19.1 to v1.21.0 (one of its motivations is to provide support for ppc64le and s390x arches) May 24, 2022
@aemperador aemperador force-pushed the aemperador/bump-opm-version branch from a7022fd to 326b5b2 Compare May 24, 2022 20:02
aemperador and others added 2 commits May 24, 2022 16:15
Signed-off-by: aemperador <alexis.emperador@ibm.com>
Co-authored-by: Camila Macedo <7708031+camilamacedo86@users.noreply.github.com>
Signed-off-by: aemperador <alexis.emperador@ibm.com>
@aemperador aemperador force-pushed the aemperador/bump-opm-version branch from 326b5b2 to 9a5a413 Compare May 24, 2022 21:16
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you for the nice contribution 🥇

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2022
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 13, 2022

@aemperador: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@camilamacedo86
Copy link
Contributor

Closing this one since master branch have now a OPM version upper than that
Thank you for your collab 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants