Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release PR v1.20.0 #5712

Merged
merged 4 commits into from
Apr 28, 2022
Merged

Release PR v1.20.0 #5712

merged 4 commits into from
Apr 28, 2022

Conversation

laxmikantbpandhare
Copy link
Member

@laxmikantbpandhare laxmikantbpandhare commented Apr 28, 2022 •
edited
Loading

Description of the change:

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci openshift-ci bot requested a review from marc-obrien April 28, 2022 19:13
rashmigottipati
rashmigottipati reviewed Apr 28, 2022
View reviewed changes
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the changelog is not generated correctly. I don't see any release notes.

asmacdo
asmacdo suggested changes Apr 28, 2022
View reviewed changes
website/config.toml-E Outdated Show resolved Hide resolved
@laxmikantbpandhare
Copy link
Member Author

Looks like the changelog is not generated correctly. I don't see any release notes.

@rashmigottipati - Yes, updated it.

@laxmikantbpandhare
Release v1.20.0
bb4228c 
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
varshaprasad96
varshaprasad96 reviewed Apr 28, 2022
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit from my end, and /lgtm after @asmacdo review is addressed.

changelog/generated/v1.20.0.md Outdated Show resolved Hide resolved
@laxmikantbpandhare
added changelog
b4ab2a2 
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
@laxmikantbpandhare
removed website/config.toml-E file
29a3372 
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
@laxmikantbpandhare
modified changelog content
a846a8f 
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
asmacdo
asmacdo approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@asmacdo asmacdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Not sure whats going on with that extra netlify.toml, but uncommitting the file and raising #5713 is sufficient for me.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2022
rashmigottipati
rashmigottipati approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@laxmikantbpandhare laxmikantbpandhare merged commit deb3531 into operator-framework:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theishshah theishshah theishshah approved these changes

@rashmigottipati rashmigottipati rashmigottipati approved these changes

@asmacdo asmacdo asmacdo approved these changes

@marc-obrien marc-obrien Awaiting requested review from marc-obrien

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@asmacdo asmacdo

@rashmigottipati rashmigottipati

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@laxmikantbpandhare @asmacdo @rashmigottipati @theishshah @varshaprasad96